-
Notifications
You must be signed in to change notification settings - Fork 62
Add androidx.health.connect bindings to support HealthConnect Records IRecord interface #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-1205
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
df90be5
Initial plan
Copilot 9f95941
Add androidx.health.connect.connect-client and dependencies to config…
Copilot 605bcb5
Run component governance, namespace file, and list artifacts utilities
Copilot 953a688
Fix missing androidx.health.connect.connect-client-external-protobuf …
Copilot 314710d
Add Transforms.xml to remove C# code from androidx.health.connect.con…
Copilot f131f47
Add partial fixes for AndroidX Health Connect Client binding errors -…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to also run:
And commit the changes from those files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed all three utility commands as requested:
dotnet cake utilities.cake -t=generate-component-governance
- Updated cgmanifest.jsondotnet cake utilities.cake -t=generate-namespace-file
- Updated published-namespaces.txtdotnet cake utilities.cake -t=list-artifacts
- Updated artifact list filesAll changes committed in 605bcb5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be an additional package that's missing:
If you're able to fix this, run the cake targets again:
generate-component-governance
,generate-namespace-file
.If you're not able to fix, tell me the errors and what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the missing package issue. The problem was that
androidx.health.connect:connect-client-external-protobuf
was marked asdependencyOnly: true
in config.json, preventing the binderator from generating a standalone binding project for it. However, theconnect-client-proto
project needed to reference it as a PackageReference.Removed the
dependencyOnly
flag, regenerated projects with binderator, and ran all three utility commands as requested. The external protobuf package should now be available for other projects to reference. Committed in 953a688.