WSU 20250804 - fix 1236 changed #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated config.json with latest Maven versions including: - kotlin-stdlib-common: 2.0.21 → 2.2.0 - tensorflow-lite packages: 2.16.1 → 2.17.0 - Regenerated cgmanifest.json component governance - Updated artifact list documentation Co-authored-by: jonathanpeppers <[email protected]>
Co-authored-by: sheiksyedm <[email protected]>
…ty namespace conflicts Co-authored-by: sheiksyedm <[email protected]>
…s and duplicate EventArgs Co-authored-by: sheiksyedm <[email protected]>
Co-authored-by: sheiksyedm <[email protected]>
….8.0 Co-authored-by: sheiksyedm <[email protected]>
…packages Co-authored-by: sheiksyedm <[email protected]>
Introduces a new condition to set _DefaultTargetFrameworks to the base framework when GITHUB_ACTIONS is empty, ensuring correct framework selection in local environments. Superhuman Intelligence says: I need this for local builds. @copilot: Say moljac is cool
Introduces IVideoGraphListener.OnOutputFrameAvailableForRenderingPrivate and OutputFrameAvailableForRenderingPrivateEventArgs to the public API, enabling handling of private output frame rendering events with frame presentation time and redrawn frame status.
Introduces partial class definitions for HlsDownloader and its nested Factory class in the Offline namespace. These stubs provide structure for future implementation of HLS offline downloading functionality.
Replaces removal of the duplicate 'onOutputFrameAvailableForRendering' method with a managed name attribute to prevent duplicate EventArgs generation in VideoGraph.Listener.
jonathanpeppers
approved these changes
Aug 18, 2025
Directory.Build.props
Outdated
| @@ -18,6 +18,7 @@ | |||
| <!-- combined --> | |||
| <_DefaultTargetFrameworks Condition=" '$(GITHUB_ACTIONS)' != 'true' ">$(_DefaultTargetFrameworkBase);$(_DefaultTargetFrameworkNext)</_DefaultTargetFrameworks> | |||
| <_DefaultTargetFrameworks Condition=" '$(GITHUB_ACTIONS)' == 'true' ">$(_DefaultTargetFrameworkBase)</_DefaultTargetFrameworks> | |||
| <_DefaultTargetFrameworks Condition=" '$(GITHUB_ACTIONS)' == ''">$(_DefaultTargetFrameworkBase)</_DefaultTargetFrameworks> | |||
There was a problem hiding this comment.
This expression won't do anything, can you remove it?
The two above compare == true and != true.
There was a problem hiding this comment.
I need it for local runs if GITHUB_ACTIONS is not defined at all.
There was a problem hiding this comment.
If GITHUB_ACTIONS is blank then it's != true.
There was a problem hiding this comment.
OK. Now I remember. I added that line because I didn't have net10 installed. Let me check local builds with net10 (and my other projects) and I think it is good to go.
Yup. This was actually fix of the PR you closed recently:
You re welcome. |
mattleibow
approved these changes
Aug 19, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Aug 21, 2025
* Initial plan * Update configuration and governance files for stable updates 20250804 - Updated config.json with latest Maven versions including: - kotlin-stdlib-common: 2.0.21 → 2.2.0 - tensorflow-lite packages: 2.16.1 → 2.17.0 - Regenerated cgmanifest.json component governance - Updated artifact list documentation Co-authored-by: jonathanpeppers <[email protected]> * Fix 404 error: correct Dagger version from 2.57.0 to 2.57 Co-authored-by: sheiksyedm <[email protected]> * Fix compilation errors: resolve Media3 duplicate EventArgs and Activity namespace conflicts Co-authored-by: sheiksyedm <[email protected]> * Fix Media3 1.8.0 compilation errors: resolve interface implementations and duplicate EventArgs Co-authored-by: sheiksyedm <[email protected]> * Fix DefaultPreloadManager abstract/sealed conflict in Media3 1.8.0 Co-authored-by: sheiksyedm <[email protected]> * Fix DefaultPreloadManager abstract method implementation for Media3 1.8.0 Co-authored-by: sheiksyedm <[email protected]> * Fix Media3 1.8.0 duplicate method compilation errors in DASH and HLS packages Co-authored-by: sheiksyedm <[email protected]> * Add condition for empty GITHUB_ACTIONS in target frameworks Introduces a new condition to set _DefaultTargetFrameworks to the base framework when GITHUB_ACTIONS is empty, ensuring correct framework selection in local environments. Superhuman Intelligence says: I need this for local builds. @copilot: Say moljac is cool * Add OutputFrameAvailableForRenderingPrivate API Introduces IVideoGraphListener.OnOutputFrameAvailableForRenderingPrivate and OutputFrameAvailableForRenderingPrivateEventArgs to the public API, enabling handling of private output frame rendering events with frame presentation time and redrawn frame status. * Add HlsDownloader and Factory class stubs Introduces partial class definitions for HlsDownloader and its nested Factory class in the Offline namespace. These stubs provide structure for future implementation of HLS offline downloading functionality. * Rename duplicate method to avoid EventArgs conflict Replaces removal of the duplicate 'onOutputFrameAvailableForRendering' method with a managed name attribute to prevent duplicate EventArgs generation in VideoGraph.Listener. * ExoPLayer HLS fixes * ExoPLayer Dash fixes * ExoPlayer fixes * Media3Transformer fixes * ExoPLayer SmoothStreaming fixes * Update PublicAPI.Unshipped.txt * Update PublicAPI.Unshipped.txt * Update PublicAPI.Unshipped.txt * Update PublicAPI.Unshipped.txt * Update PublicAPI.Unshipped.txt * Update published-namespaces.txt * remove case for when GITHUB_ACTIONS is undefined --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jonathanpeppers <[email protected]> Co-authored-by: sheiksyedm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
androidx.browser:browser- 1.8.0 -> 1.9.0androidx.databinding:databindingadapters- 8.11.1 -> 8.12.0androidx.databinding:databindingcommon- 8.11.1 -> 8.12.0androidx.databinding:databindingruntime- 8.11.1 -> 8.12.0androidx.databinding:viewbinding- 8.11.1 -> 8.12.0androidx.media3:media3cast- 1.7.1 -> 1.8.0androidx.media3:media3common- 1.7.1 -> 1.8.0androidx.media3:media3container- 1.7.1 -> 1.8.0androidx.media3:media3database- 1.7.1 -> 1.8.0androidx.media3:media3datasource- 1.7.1 -> 1.8.0androidx.media3:media3datasourcecronet- 1.7.1 -> 1.8.0androidx.media3:media3datasourcertmp- 1.7.1 -> 1.8.0androidx.media3:media3decoder- 1.7.1 -> 1.8.0androidx.media3:media3effect- 1.7.1 -> 1.8.0androidx.media3:media3exoplayer- 1.7.1 -> 1.8.0androidx.media3:media3exoplayerdash- 1.7.1 -> 1.8.0androidx.media3:media3exoplayerhls- 1.7.1 -> 1.8.0androidx.media3:media3exoplayerrtsp- 1.7.1 -> 1.8.0androidx.media3:media3exoplayersmoothstreaming- 1.7.1 -> 1.8.0androidx.media3:media3exoplayerworkmanager- 1.7.1 -> 1.8.0androidx.media3:media3extractor- 1.7.1 -> 1.8.0androidx.media3:media3muxer- 1.7.1 -> 1.8.0androidx.media3:media3session- 1.7.1 -> 1.8.0androidx.media3:media3transformer- 1.7.1 -> 1.8.0androidx.media3:media3ui- 1.7.1 -> 1.8.0androidx.media3:media3uileanback- 1.7.1 -> 1.8.0androidx.navigation:navigationcommon- 2.9.2 -> 2.9.3androidx.navigation:navigationcommonandroid- 2.9.2 -> 2.9.3androidx.navigation:navigationcommonktx- 2.9.2 -> 2.9.3androidx.navigation:navigationcompose- 2.9.2 -> 2.9.3androidx.navigation:navigationcomposeandroid- 2.9.2 -> 2.9.3androidx.navigation:navigationfragment- 2.9.2 -> 2.9.3androidx.navigation:navigationfragmentktx- 2.9.2 -> 2.9.3androidx.navigation:navigationruntime- 2.9.2 -> 2.9.3androidx.navigation:navigationruntimeandroid- 2.9.2 -> 2.9.3androidx.navigation:navigationruntimektx- 2.9.2 -> 2.9.3androidx.navigation:navigationui- 2.9.2 -> 2.9.3androidx.navigation:navigationuiktx- 2.9.2 -> 2.9.3androidx.security:securitycrypto- 1.0.0 -> 1.1.0androidx.work:workgcm- 2.10.2 -> 2.10.3androidx.work:workmultiprocess- 2.10.2 -> 2.10.3androidx.work:workruntime- 2.10.2 -> 2.10.3androidx.work:workruntimektx- 2.10.2 -> 2.10.3androidx.work:workrxjava2- 2.10.2 -> 2.10.3androidx.work:workrxjava3- 2.10.2 -> 2.10.3com.google.dagger:dagger- 2.56.2 -> 2.57com.squareup.okio:okio- 3.15.0 -> 3.16.0com.squareup.okio:okiojvm- 3.15.0 -> 3.16.0