Skip to content

[tests] ignore transient "Broken pipe" network errors #10681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Jan 16, 2026
Merged

[tests] ignore transient "Broken pipe" network errors #10681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5251d3
[tests] ignore transient "Broken pipe" network errors
jonathanpeppers Jan 13, 2026
83a8e95
Make IgnoreIfConnectionFailed method protected
jonathanpeppers Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidClientHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,15 @@ protected void RunIgnoringNetworkIssues (Action runner, out bool connectionFaile
}
}

bool IgnoreIfConnectionFailed (AggregateException aex, out bool connectionFailed)
protected bool IgnoreIfConnectionFailed (AggregateException aex, out bool connectionFailed)
{
if (IgnoreIfConnectionFailed (aex.InnerException as HttpRequestException, out connectionFailed))
return true;

return IgnoreIfConnectionFailed (aex.InnerException as WebException, out connectionFailed);
if (IgnoreIfConnectionFailed (aex.InnerException as WebException, out connectionFailed))
return true;

return IgnoreIfSocketException (aex, out connectionFailed);
}

bool IgnoreIfConnectionFailed (HttpRequestException hrex, out bool connectionFailed)
Expand All @@ -145,6 +148,26 @@ bool IgnoreIfConnectionFailed (WebException wex, out bool connectionFailed)

return false;
}

bool IgnoreIfSocketException (Exception ex, out bool connectionFailed)
{
connectionFailed = false;
// Check the exception and all inner exceptions for transient socket errors
var current = ex;
while (current != null) {
if (current is Java.Net.SocketException socketEx) {
var message = socketEx.Message ?? "";
if (message.Contains ("Broken pipe", StringComparison.OrdinalIgnoreCase) ||
message.Contains ("Connection reset", StringComparison.OrdinalIgnoreCase)) {
connectionFailed = true;
Assert.Ignore ($"Ignoring transient socket error: {socketEx}");
return true;
}
}
current = current.InnerException;
}
return false;
}
}

[Category ("AndroidClientHandler")]
Expand Down
7 changes: 7 additions & 0 deletions ...s/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,13 @@ public async Task HttpContentStreamIsRewoundAfterCancellation ()
try {
await client.SendAsync (request, tcs.Token).ConfigureAwait (false);
// If we get here without exception, that's also OK for this test
} catch (AggregateException ex) {
if (IgnoreIfConnectionFailed (ex, out _))
return;
// Expected - cancellation or connection error
// We catch all exceptions to ensure the test doesn't fail due to unhandled exceptions
Console.WriteLine ($"Exception during first request (expected): {ex}");
exceptionThrown = true;
} catch (Exception ex) {
// Expected - cancellation or connection error
// We catch all exceptions to ensure the test doesn't fail due to unhandled exceptions
Expand Down