Skip to content

fix: allow fork PRs to pass validation when commenting fails #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 1 commit into from
Mar 24, 2026
Merged

fix: allow fork PRs to pass validation when commenting fails #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ jobs:

- name: Post or update PR comment
if: always() && github.event_name == 'pull_request' && steps.validate.outputs.has_comment == 'true'
continue-on-error: true # GITHUB_TOKEN is read-only for fork PRs (dotnet/arcade-skills#13)
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true will ignore all failures in the comment step, including same-repo PRs where a failure might indicate a real regression (e.g., API shape changes, auth misconfig, rate limiting). If the intent is only to tolerate fork PR permission restrictions, consider making this conditional (e.g., only for fork PRs) so unexpected failures still fail the job in trusted contexts.

Suggested change
continue-on-error: true # GITHUB_TOKEN is read-only for fork PRs (dotnet/arcade-skills#13)
continue-on-error: ${{ github.event.pull_request.head.repo.fork == true }} # GITHUB_TOKEN is read-only for fork PRs (dotnet/arcade-skills#13)

Copilot uses AI. Check for mistakes.
env:
GH_TOKEN: ${{ github.token }}
shell: bash
Expand Down
Loading