Skip to content

fix: scope continue-on-error to fork PRs only in comment step#17

Merged
danmoseley merged 2 commits intomainfrom
copilot/fix-continue-on-error-feedback
Mar 24, 2026
Merged

fix: scope continue-on-error to fork PRs only in comment step#17
danmoseley merged 2 commits intomainfrom
copilot/fix-continue-on-error-feedback

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

continue-on-error: true on the PR comment step silently swallows all failures — including same-repo PRs where errors indicate real problems (auth misconfiguration, rate limiting, API changes).

Change

Make continue-on-error conditional on whether the PR originates from a fork:

- name: Post or update PR comment
  continue-on-error: ${{ github.event.pull_request.head.repo.fork == true }}  # GITHUB_TOKEN is read-only for fork PRs (dotnet/arcade-skills#13)

Fork PRs still tolerate the expected HTTP 403 (read-only GITHUB_TOKEN). Same-repo PRs now fail the job on unexpected comment errors.

Original prompt

This section details on the original issue you should resolve

<issue_title>feedback on #15</issue_title>
<issue_description>address "continue-on-error: true will ignore all failures in the comment step" feedback on #15</issue_description>

Comments on the Issue (you are @copilot in this section)


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI changed the title [WIP] Address feedback on continue-on-error behavior fix: scope continue-on-error to fork PRs only in comment step Mar 24, 2026
Copilot AI requested a review from danmoseley March 24, 2026 18:53
@danmoseley danmoseley marked this pull request as ready for review March 24, 2026 19:01
Copilot AI review requested due to automatic review settings March 24, 2026 19:01
@github-actions
Copy link
Copy Markdown

Warnings (4)

  • plugins/dotnet-dnceng/skills/ci-analysis — ~2971 tokens (chars/4) — approaching 'comprehensive' range where gains diminish.
  • plugins/dotnet-dnceng/skills/ci-crash-dump — ~3892 tokens (chars/4) — approaching 'comprehensive' range where gains diminish.
  • plugins/dotnet-dnceng/skills/ci-crash-dump — no numbered workflow steps — agents follow sequenced procedures more reliably.
  • plugins/dotnet-dnceng/skills/flow-analysis — ~5442 tokens (chars/4) — 'comprehensive' skills hurt performance. Consider splitting into 2-3 focused skills.

View workflow run

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR validation workflow so that failures in the “Post or update PR comment” step are only tolerated for fork-based PRs (where GITHUB_TOKEN is read-only and comment posting is expected to fail), while same-repo PRs will now fail the job if commenting errors occur—surfacing real problems like auth/rate-limit/API issues.

Changes:

  • Make continue-on-error conditional on whether the pull request originates from a fork (github.event.pull_request.head.repo.fork).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danmoseley danmoseley merged commit 063824a into main Mar 24, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feedback on #15

4 participants