fix: scope continue-on-error to fork PRs only in comment step#17
Merged
danmoseley merged 2 commits intomainfrom Mar 24, 2026
Merged
fix: scope continue-on-error to fork PRs only in comment step#17danmoseley merged 2 commits intomainfrom
danmoseley merged 2 commits intomainfrom
Conversation
Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/arcade-skills/sessions/0fa79117-2e79-4a13-8186-a57551c3ecb8
Copilot
AI
changed the title
[WIP] Address feedback on continue-on-error behavior
fix: scope continue-on-error to fork PRs only in comment step
Mar 24, 2026
Warnings (4)
|
There was a problem hiding this comment.
Pull request overview
Updates the PR validation workflow so that failures in the “Post or update PR comment” step are only tolerated for fork-based PRs (where GITHUB_TOKEN is read-only and comment posting is expected to fail), while same-repo PRs will now fail the job if commenting errors occur—surfacing real problems like auth/rate-limit/API issues.
Changes:
- Make
continue-on-errorconditional on whether the pull request originates from a fork (github.event.pull_request.head.repo.fork).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lewing
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue-on-error: trueon the PR comment step silently swallows all failures — including same-repo PRs where errors indicate real problems (auth misconfiguration, rate limiting, API changes).Change
Make
continue-on-errorconditional on whether the PR originates from a fork:Fork PRs still tolerate the expected HTTP 403 (read-only
GITHUB_TOKEN). Same-repo PRs now fail the job on unexpected comment errors.Original prompt
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.