Update 3 skills: ci-analysis-flow-analysis-flow-tracing#4
Update 3 skills: ci-analysis-flow-analysis-flow-tracing#4
Conversation
Synced from copilot-skills
7ca4d35 to
40e915e
Compare
Warnings (2)
|
There was a problem hiding this comment.
Pull request overview
This PR syncs updated dotnet-dnceng skill content from the copilot-skills marketplace, expanding the repo’s operational playbooks and scripts for CI investigation, codeflow health analysis, and dependency/SDK version tracing in the VMR ecosystem.
Changes:
- Added flow-tracing skill docs + a PowerShell script to trace component SHAs from an SDK version (including servicing topology guidance).
- Added flow-analysis skill docs + a new
flow-health.csbatch scanner (and updated the existing PowerShell variant). - Updated ci-analysis skill content, including an updated
Get-CIStatus.ps1and a large set of reference guides.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1 | New script to decode SDK versions, map to VMR branch/build, and resolve component SHAs (with optional local git ancestry checks). |
| plugins/dotnet-dnceng/skills/flow-tracing/references/servicing-topology.md | New reference describing 1xx vs 2xx/3xx servicing dependency topology and tracing implications. |
| plugins/dotnet-dnceng/skills/flow-tracing/references/sdk-version-format.md | New reference explaining SDK version encoding/decoding (SHORT_DATE) and branch mapping. |
| plugins/dotnet-dnceng/skills/flow-tracing/references/azdo-pipelines.md | New reference documenting key AzDO pipelines/orgs for VMR builds and how to query them. |
| plugins/dotnet-dnceng/skills/flow-tracing/SKILL.md | New skill definition and workflow guidance for cross-repo and SDK-version dependency tracing. |
| plugins/dotnet-dnceng/skills/flow-analysis/scripts/flow-health.cs | New C# script to batch-scan codeflow PR health via gh in parallel (repo-wide health snapshot). |
| plugins/dotnet-dnceng/skills/flow-analysis/scripts/Get-FlowHealth.ps1 | Updated PowerShell script for repo-wide codeflow health scanning (parallel when available). |
| plugins/dotnet-dnceng/skills/flow-analysis/references/vmr-codeflow-reference.md | New reference explaining codeflow concepts, PR metadata markers, and remediation commands. |
| plugins/dotnet-dnceng/skills/flow-analysis/references/vmr-build-topology.md | New reference for diagnosing widespread backflow staleness using build topology + public signals. |
| plugins/dotnet-dnceng/skills/flow-analysis/SKILL.md | New skill definition and end-to-end workflow for diagnosing flow health with scripts + MCP enrichment. |
| plugins/dotnet-dnceng/skills/ci-analysis/scripts/Get-CIStatus.ps1 | Updated CI investigation script for AzDO/Helix triage with caching and structured JSON output. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/sql-tracking.md | New reference for tracking CI investigations in SQL (failed jobs, PR comments, artifacts). |
| plugins/dotnet-dnceng/skills/ci-analysis/references/script-modes.md | New reference documenting script parameter modes and expected inputs. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/recommendation-generation.md | New reference describing how to synthesize actionable recommendations from script output. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/manual-investigation.md | New reference outlining manual AzDO/Helix investigation fallback steps. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/helix-artifacts.md | New reference for locating and interpreting Helix artifacts (binlogs, dumps, logs). |
| plugins/dotnet-dnceng/skills/ci-analysis/references/failure-interpretation.md | New reference for categorizing failures and recovering results from canceled/crashed jobs. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/delegation-patterns.md | New reference describing subagent delegation patterns for repetitive CI investigation tasks. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/build-progression-analysis.md | New reference for analyzing pass/fail progression across multiple PR builds. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/binlog-comparison.md | New reference for binlog comparison workflow (including delegation guidance). |
| plugins/dotnet-dnceng/skills/ci-analysis/references/azure-cli.md | New reference for Azure CLI fallback workflows (artifact download, pipelines queries). |
| plugins/dotnet-dnceng/skills/ci-analysis/references/azdo-helix-reference.md | New reference explaining AzDO org/project mapping and Helix-related investigation tips. |
| plugins/dotnet-dnceng/skills/ci-analysis/references/analysis-workflow.md | New reference describing the primary analysis workflow steps (script-first, then enrich). |
| plugins/dotnet-dnceng/skills/ci-analysis/SKILL.md | New/updated ci-analysis skill definition and guidance for using the script + tools effectively. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/dotnet-dnceng/skills/flow-tracing/references/servicing-topology.md
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/references/servicing-topology.md
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-analysis/scripts/flow-health.cs
Outdated
Show resolved
Hide resolved
Required by flow-analysis and flow-tracing skills for subscription health, build freshness, and codeflow management queries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- flow-health.cs: Read stdout/stderr async to prevent deadlock on full stderr buffer; handle WaitForExit timeout by killing process - Get-SdkVersionTrace.ps1: Normalize preview.1→preview1 for VMR branch names; fix fallback text to reference <Sha> element not attribute; replace MCP tool name with generic guidance - servicing-topology.md: Fix Sha attribute→<Sha> element; fix source-manifest.json path to src/source-manifest.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/ci-analysis/scripts/Get-CIStatus.ps1
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/ci-analysis/scripts/Get-CIStatus.ps1
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "args": [ | ||
| "dnx", | ||
| "--yes", | ||
| "lewing.maestro.mcp" |
There was a problem hiding this comment.
where is the source for this / how is it hosted?
we presumably should be thoughtful about exposing privately hosted MCP's as blessed product infrastructure?
There was a problem hiding this comment.
|
I assume we don't want the VMR skills in dotnet/dotnet, because they can be useful from any repo. My only question is the one about what our policy is for exposing private MCP's. Otherwise LGTM |
They are for managing / tracing flow on any repo and branch. Sticking them in specific repos and branches less ideal. They could be in a separate flow related plugin here if it is important although they do
We can put the mcps somewhere not personal if needed just tell where. Ci-analysis works much better with the helix mcp and I'm going to rework it to leverage it even more but i can probably keep it limping along without. |
|
OK sounds appropriate to have the VMR ones here. No opinion about a plugin. For the MCP's what do you need, if just a repo then how about here. What hosts them - some personal setup with Azure VM's? what you do suggest. |
…rigger Trained from sessions analyzing Maestro bookkeeping bug. Changes: - Add Step 0: codeflow statuses as fast-path entry point - Expand forward flow diagnosis with bookkeeping bug pattern - Add cross-validation via validate option on subscription health - Update remediation: smart trigger, force-trigger via MCP Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ci-analysis: remove slop, tighten reference docs, drop ADO MCP dependency - flow-analysis: sync latest content - flow-tracing: sync latest content Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
plugins/dotnet-dnceng/skills/flow-analysis/scripts/flow-health.cs
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Outdated
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Show resolved
Hide resolved
plugins/dotnet-dnceng/skills/flow-analysis/references/vmr-build-topology.md
Outdated
Show resolved
Hide resolved
…separate skill) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- flow-health.cs: properly async (WaitForExitAsync), SemaphoreSlim throttle, gh failure tracking with non-zero exit, auth check at startup, forward-flow ci-red count fix in summary - Get-SdkVersionTrace.ps1: Invoke-RestMethod instead of Invoke-WebRequest, single-match constraint in Find-ComponentInManifest, 1xx GA branch fallback to main, gh api fallback text - vmr-build-topology.md: HttpClient instead of Invoke-WebRequest in example Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Helix MCP (hlx) now provides all the AzDO pipeline and artifact functionality that ci-analysis needs. The separate ado-dnceng and ado-dnceng-public MCP servers are no longer required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
plugins/dotnet-dnceng/skills/flow-tracing/scripts/Get-SdkVersionTrace.ps1
Outdated
Show resolved
Hide resolved
- flow-health.cs: use try/catch TimeoutException instead of ContinueWith - Get-SdkVersionTrace.ps1: URL-encode branch name in gh api call - ci-analysis SKILL.md: fix dangling binlog-comparison skill reference Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
here isn't ideal just because it gets cloned when you add the marketplace when using some clients but I can put them here if there is no better place for now. We'd probably want to publish to the tools feed |
|
Is there something I should be doing to move this along? |
|
dotnet/sdk#53526 is a the direction I would like to take things. If the maestro.mcp config is holing this up I can split it out? |
|
It looks like you are syncing these skills from another repo? I have comments/suggestions, but would rather add them at the source if that's the case. |
invite sent |
Summary
Syncs 3 dnceng skills from blazor-playground/copilot-skills:
Changes
plugin.jsonfor flow-analysis/flow-tracing skills<Sha>element wording,src/source-manifest.jsonpathapi/2019-06-17/endpoints consistentlySource
blazor-playground/copilot-skills @ main