Run ComputeRunArguments only for MTP #15742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Apr 15, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Looks good but I would hold off with this change until we see another instance failing because of the missing target. AspNetCore is a special case as they have projects that don't use the Microsoft.NET.Sdk but use the testing infra from Arcade. That's already fixed in the aspnetcore PR now.
Member
Author
|
Closing for now. We can reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/aspnetcore#61497
@ViktorHofer I haven't verified this fix against aspnetcore. Could you do for me please?