Use mssql instead of azure-sql-edge for ServiceBus Emulator #10378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the `azure-sql-edge` container for `mssql/server` as Azure SQL Edge is retiring in September 2025. Relates to dotnet#9279.
github-actions
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the retiring azure-sql-edge emulator image with the official mssql/server image for the Azure ServiceBus emulator.
- Switch container image constants from Azure SQL Edge to SQL Server
- Update emulator extension to create and reference an
-mssqlcontainer instead of-sqledge - Adjust corresponding test to look for
sb-mssqlrather thansb-sqledge
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs | Test updated to expect the resource named sb-mssql instead of sb-sqledge. |
| src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs | Renamed constants from AzureSqlEdge* to SqlServer* and updated <remarks> to reflect mssql/server. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs | Updated container addition and references to use -mssql, SqlServerImage, SqlServerTag, and SqlServerRegistry. |
Comments suppressed due to low confidence (2)
tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs:613
- Consider adding assertions to verify that the container image registry, image name, and tag on the
sb-mssqlresource matchServiceBusEmulatorContainerImageTags.SqlServerRegistry,SqlServerImage, andSqlServerTagto ensure the switch tomssql/serveris fully validated in tests.
var sql = builder.Resources.FirstOrDefault(x => x.Name == "sb-mssql");
src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs:15
- [nitpick] The constant name
Tagis quite generic; consider renaming it to something more descriptive such asServiceBusEmulatorVersionorEmulatorTagto clarify its purpose.
public const string Tag = "1.1.2";
martincostello
added a commit
to martincostello/docs-aspire
that referenced
this pull request
Jul 14, 2025
Update the companion image for the ServiceBus emulator. Relates to dotnet/aspire#10378.
martincostello
added
azure-servicebus
azure
|
[Nudge as support ends in just over a month] |
eerhardt
reviewed
Sep 2, 2025
There was a problem hiding this comment.
Thanks for the fix here @martincostello. I just have 1 comment. Other than that, this looks good.
|
|
||
| /// <remarks>latest</remarks> | ||
| public const string AzureSqlEdgeTag = "latest"; | ||
| public const string SqlServerTag = "latest"; |
There was a problem hiding this comment.
I think we should pin this to a version, like we do with the real SqlServer hosting integration:
This way we will be less likely to get breaking changes.
eerhardt
reviewed
Sep 2, 2025
src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Sep 2, 2025
IEvangelist
added a commit
to dotnet/docs-aspire
that referenced
this pull request
Sep 3, 2025
* Update ServiceBus emulator child image name Update the companion image for the ServiceBus emulator. Relates to dotnet/aspire#10378. * Improve clarity around Application Insights integration options (#4259) * Initial plan * Add telemetry options section to Application Insights documentation Co-authored-by: IEvangelist <[email protected]> * Convert Microsoft Learn links to site-relative URLs Co-authored-by: IEvangelist <[email protected]> * Add missing periods to bullet lists and table descriptions Co-authored-by: adegeo <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: IEvangelist <[email protected]> Co-authored-by: adegeo <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: IEvangelist <[email protected]> Co-authored-by: adegeo <[email protected]> Co-authored-by: David Pine <[email protected]>
Copilot AI
pushed a commit
that referenced
this pull request
Sep 3, 2025
* Use mssql instead of azure-sql-edge for ServiceBus Switch the `azure-sql-edge` container for `mssql/server` as Azure SQL Edge is retiring in September 2025. Relates to #9279. * Use 2022-latest tag for ServiceBus emulator Addresses feedback. * Update src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs --------- Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch the
azure-sql-edgecontainer formssql/serverfor the Azure ServiceBus emulator as Azure SQL Edge is retiring in September 2025.Relates to #9279. Provides the switch from the to-be-retired image, but does not introduce the ability to allow the user to configure the dependent SQL Server image proposed.
Checklist
Yes. Ready to ship.NoYesYesNo