Remove IResourceWithoutLifetime on everything

[davidfowl]

Description

This comes after a long discussion on discord https://discord.com/channels/1361488941836140614/1402388529975263294 about the ability to WaitFor a parameter resource without using the value directly. Originally parameters we considered resources without a lifetime and we made it impossible to WaitFor them since their values could not change at runtime. With the new support to allow setting parameter values at runtime this has changed.

• ParameterResources can now be waited on
• Move init logic to ConnectionStringResource class and simplify it. Delete special logic for WaitFor ConnectionStringResource.
• Changed state to Running for ParameterResource and ConnectionStringResource

Also Fixes #10827

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
• Are you including unit tests for the changes and scenario tests if relevant?
  • No
• Did you add public API?
  • No
• Does the change make any security assumptions or guarantees?
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue (consider using one of the following templates):
      • New (or update) doc-idea template
      • New breaking-change template
      • New diagnostic template

[Copilot]

Pull Request Overview

This PR removes the IResourceWithoutLifetime interface from various resource types to enable waiting functionality on parameter and connection string resources. The change allows parameters and connection strings to participate in the normal resource lifecycle, making them awaitable through WaitFor operations.

• Removes IResourceWithoutLifetime from ParameterResource, ConnectionStringResource, and ExternalServiceResource
• Moves connection string initialization logic from the orchestrator to the ConnectionStringResource class
• Updates resource states to use Running instead of Active for parameter and connection string resources

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Aspire.Hosting.Tests/ExternalServiceTests.cs	Removes test that verified ExternalServiceResource implements IResourceWithoutLifetime
src/Aspire.Hosting/ResourceBuilderExtensions.cs	Removes special case logic for waiting on ConnectionStringResource dependencies
src/Aspire.Hosting/ParameterResourceBuilderExtensions.cs	Removes parameter.secret property from parameter resource properties
src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs	Changes parameter resource state from Active to Running
src/Aspire.Hosting/Orchestrator/ApplicationOrchestrator.cs	Removes connection string initialization logic and event subscription
src/Aspire.Hosting/ExternalServiceResource.cs	Removes IResourceWithoutLifetime interface implementation
src/Aspire.Hosting/ConnectionStringResource.cs	Removes IResourceWithoutLifetime interface implementation
src/Aspire.Hosting/ConnectionStringBuilderExtensions.cs	Adds initialization logic with dependency waiting and state management

[Copilot]

The code waits for resources to be healthy, but connection string resolution might only need the referenced resources to have their connection strings available, not necessarily be healthy. This could cause unnecessary delays or failures if a referenced resource is running but not yet healthy.

Suggested change

	tasks.Add(evt.Notifications.WaitForResourceHealthyAsync(referencedResource.Name, ct));
	tasks.Add(evt.Notifications.WaitForResourceRunningAsync(referencedResource.Name, ct));

[davidfowl]

I think this is a reasonable suggestion tbh. The resource does not need to be healthy to get the value of the connection string. That said, this affects consumers of the ConnectionStringAvailableEvent, not users of ConnectionStringExpression

[davidfowl]

Would love feedback on:

1. Should I leave Active as the status and update the health check code and wait for code to look for both Active and Running?

[mitchdenny]

This is removed but I'm not seeing where it is injected elsewhere, are we just relying on parameter value now?

[davidfowl]

I didn't need to remove it but it does nothing today 😄