-
Notifications
You must be signed in to change notification settings - Fork 668
Rename Application to Resource in dashboard OTLP functionality #10868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…updated Co-authored-by: JamesNK <[email protected]>
…ge and model classes Co-authored-by: JamesNK <[email protected]>
…el and core updates Co-authored-by: JamesNK <[email protected]>
…ional model and component files Co-authored-by: JamesNK <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR comprehensively renames "Application" to "Resource" throughout the dashboard OTLP functionality to align with proper OpenTelemetry terminology. In OpenTelemetry, the correct term for entities that generate telemetry data is "resource" rather than "application".
Key Changes:
- File renames for core OTLP model classes and helper utilities
- Class and type name updates from Application/OtlpApplication to Resource/OtlpResource
- Property and method renames throughout the storage layer, view models, and UI components
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
TelemetryRepository.cs | Updated storage layer methods and collections from Application to Resource terminology |
Subscription.cs | Changed ApplicationKey property to ResourceKey |
ResourceKey.cs | Renamed struct from ApplicationKey to ResourceKey with updated methods |
GetTracesRequest.cs | Updated ApplicationKey property to ResourceKey |
GetLogsContext.cs | Updated ApplicationKey property to ResourceKey |
GetInstrumentRequest.cs | Updated ApplicationKey property to ResourceKey |
OtlpTrace.cs | Updated method parameter from OtlpApplication to OtlpResource |
OtlpSpan.cs | Updated Source property and uninstrumented peer from Application to Resource types |
OtlpResourceView.cs | Renamed class from OtlpApplicationView with updated properties |
OtlpResourceType.cs | Renamed enum from OtlpApplicationType |
OtlpResource.cs | Renamed class from OtlpApplication with updated properties and methods |
OtlpLogEntry.cs | Updated ApplicationView property to ResourceView |
OtlpHelpers.cs | Renamed GetApplicationKey method to GetResourceKey |
TracesViewModel.cs | Updated ApplicationKey property to ResourceKey |
TraceHelpers.cs | Updated OrderedApplication class to OrderedResource with related method updates |
StructuredLogsViewModel.cs | Updated ApplicationKey property to ResourceKey |
SpanDetailsViewModel.cs | Updated Applications property to Resources |
ResourceTypeDetails.cs | Updated GetApplicationKey method to GetResourceKey |
SpanWaterfallViewModel.cs | Updated method parameters from Application to Resource types |
ResourcesSelectHelpers.cs | Renamed class from ApplicationsSelectHelpers with updated method names |
ExemplarsDialogViewModel.cs | Updated Applications property to Resources |
UnreadLogErrorsBadge.razor.cs | Updated Dictionary key type and variable names |
StateColumnDisplay.razor.cs | Updated Dictionary key type |
SignalsActionsDisplay.razor.cs | Updated HandleClearSignal delegate parameter type |
ClearSignalsButton.razor.cs | Updated HandleClearSignal delegate parameter type and method call |
This PR renames "Application" to "Resource" throughout the dashboard OTLP functionality to align with proper OpenTelemetry terminology. In OpenTelemetry, the correct term for the entity that generates telemetry data is "resource" rather than "application".
Changes Made
File Renames
OtlpApplication.cs
→OtlpResource.cs
OtlpApplicationType.cs
→OtlpResourceType.cs
OtlpApplicationView.cs
→OtlpResourceView.cs
ApplicationKey.cs
→ResourceKey.cs
ApplicationsSelectHelpers.cs
→ResourcesSelectHelpers.cs
Class and Type Updates
OtlpApplication
→OtlpResource
OtlpApplicationType
→OtlpResourceType
OtlpApplicationView
→OtlpResourceView
ApplicationKey
→ResourceKey
ApplicationsSelectHelpers
→ResourcesSelectHelpers
Property and Method Updates
ApplicationName
→ResourceName
ApplicationKey
→ResourceKey
GetApplications()
→GetResources()
GetApplicationByCompositeName()
→GetResourceByCompositeName()
GetApplicationKey()
→GetResourceKey()
Affected Areas
The renaming maintains full backward compatibility in terms of functionality while using the correct OpenTelemetry terminology throughout the codebase.
Addressing #10867.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.