Improve resources action menu #10869
Open
+334
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the resource action menu by preventing it from going off the side of the page when there are many commands. The solution groups non-highlighted commands into a "Commands" submenu when there are more than 5 total commands.
- Restructures the resource menu to use submenus for better layout control
- Adds a new "Commands" localized string resource
- Modifies menu components to support nested menu items
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Model/MenuButtonItem.cs | Adds NestedMenuItems property to support submenu functionality |
| src/Aspire.Dashboard/Components/Controls/AspireMenu.razor | Updates menu rendering to support nested menu items with recursive rendering |
| src/Aspire.Dashboard/Model/ResourceMenuItems.cs | Refactors menu creation logic to group commands into submenus and separates concerns |
| src/Aspire.Dashboard/Model/ResourceViewModel.cs | Changes GetDisplayDescription return type to nullable and improves empty string handling |
| src/Aspire.Dashboard/Resources/Resources.resx | Adds ResourcesCommands localization key |
| src/Aspire.Dashboard/Resources/xlf/*.xlf | Updates all localization files with new ResourcesCommands entry |
Files not reviewed (1)
- src/Aspire.Dashboard/Resources/Resources.Designer.cs: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop resource action menu from going off the side of the page by moving many commands into a sub-menu:
And do the same thing with URLs:
Fixes #10785
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate