-
Notifications
You must be signed in to change notification settings - Fork 668
Gracefully handle connection error between dashboard and app host #10880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-10879
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+380
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handling Co-authored-by: JamesNK <[email protected]>
Copilot finished work on behalf of
JamesNK
August 7, 2025 23:58
Nice! |
Hmm, the retry button won't actually do anything. Once the connect TCS is failed then that's it until the dashboard is restarted. Need to have a method on the client to force it to reconnect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dashboard cannot connect to the app host, RpcExceptions were bubbling up to Blazor's error boundary, displaying the technical yellow error bar instead of providing helpful user guidance.
This change adds graceful error handling to the
ApplicationName
component, which is one of the first components to establish connection with the app host. Now when connection fails:Before:
After:
Implementation Details
New ConnectionErrorDialog Component
Components/Dialogs/ConnectionErrorDialog.razor
using FluentUI componentsIDialogContentComponent<ConnectionErrorDialogResult>
interfaceEnhanced ApplicationName Component Error Handling
Localized Error Messages
Added new resource strings in
Dialogs.resx
:Retry Mechanism
The retry button calls
NavigationManager.NavigateTo("/", forceLoad: true)
to completely refresh the dashboard, allowing all components to re-initialize and attempt connection again.This provides a much better user experience when the app host is temporarily unavailable or takes time to start up, replacing technical error messages with clear guidance and recovery options.
Fixes #10879.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.