Skip to content

Switch grid display mode to fix scrolling #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 8, 2025

Description

This is a proper fix for the scrolling issues in grids:

  • Enables table mode on virtualized grids
  • Refactor widths to be set on columns instead of GridTemplateColumns
  • Update widths to be set as percentages instead of fractions on columns
  • Reduce overscan count to improve performance

There are some issues with this change that I believe are issues in FluentUI:

  • Empty and loading templates column span is broken
  • Pixel width columns aren't sized correctly on refresh
  • Column resizing in general doesn't feel good. Some columns can't be decreased, some columns immediately increase in size on resize

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant