Fix executable arguments showing raw manifest expressions in dashboard #10896
+64
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Aspire 9.2, executable resources started showing raw manifest expressions like
{{- portForServing "exe" -}}
instead of resolved values in the dashboard's Source column when using endpoint references in arguments.The issue was in the
ExpressionResolver
class which only handled endpoint expressions when the source was a container (sourceIsContainer = true
). For executable resources, endpoint expressions would fall through to the genericIValueProvider
case and return unresolved template expressions.Before the fix:
After the fix:
// Same code now shows the resolved port number: 12345
The fix removes the
when sourceIsContainer
condition from the endpoint expression handlers inExpressionResolver.ResolveInternalAsync()
, allowing endpoint expressions to be properly resolved for both container and executable sources. The existingEvalEndpointAsync
method already contains the correct logic to handle different communication scenarios (container-to-container, executable-to-container, etc.).Fixes #9047.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.