-
Notifications
You must be signed in to change notification settings - Fork 683
Restructure Resource Hierarchy documentation to separate IResourceWithParent from lifecycle semantics #10897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-e5c214c3-543a-4f2e-9988-94711c671ca8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4ce9558
Initial plan
Copilot 61c6592
Update Resource Hierarchy documentation to clarify structure vs lifec…
Copilot 85ebeef
Restructure Resource Hierarchy docs to separate IResourceWithParent f…
Copilot cb94889
Add link to eventing section for lifecycle coordination
Copilot b294d9d
Update docs/specs/appmodel.md
davidfowl 2cef61a
Update docs/specs/appmodel.md
davidfowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me as the desired implementation, but I'm not sure it reflects reality. There are several reported bugs about resource lifecycles behaving differently when
WithParentRelationship
is used vs it not being used.WithParentRelationship
sometimes treated likeIResourceWithParent
#9165.WaitForCompletion()
#10823There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there are still issues to work out. Today we have this lifetime behavior for all containers which is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I came here to say that -- this documentation now seems to imply that IResourceWithParent is just an inert marker interface that adds a utility Parent field, but I am 99% sure it actively does things beyond this.