-
Notifications
You must be signed in to change notification settings - Fork 703
Add Java debugger support #12076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marshalhayes
wants to merge
8
commits into
dotnet:main
Choose a base branch
from
marshalhayes:vscode-extension/java
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+141
−2
Open
Add Java debugger support #12076
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e55e8be
Start Java debug extension support
marshalhayes 09a787e
Fallback to project_path if main_class_path is not provided
marshalhayes 13c00b5
Add basic tests for Java debugger extension
marshalhayes 68668ab
Add Java to README.md, and include links to debugger extension docs
marshalhayes 8a9369f
Merge branch 'dotnet:main' into vscode-extension/java
marshalhayes 50b435f
Add .java as a supported file type, and explain why both main_class_p…
marshalhayes 1991388
Expand upon Java support in extension README.md
marshalhayes e2785cd
Determine cwd from project path
marshalhayes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { isJavaLaunchConfiguration } from "../../dcp/types"; | ||
import { invalidLaunchConfiguration } from "../../loc/strings"; | ||
import { ResourceDebuggerExtension } from "../debuggerExtensions"; | ||
|
||
export const javaDebuggerExtension: ResourceDebuggerExtension = { | ||
resourceType: 'java', | ||
debugAdapter: 'java', | ||
extensionId: 'vscjava.vscode-java-pack', | ||
displayName: 'Java', | ||
getProjectFile: (launchConfig) => { | ||
if (isJavaLaunchConfiguration(launchConfig)) { | ||
const programPath = launchConfig.main_class_path || launchConfig.project_path; | ||
if (programPath) { | ||
return programPath; | ||
} | ||
} | ||
|
||
throw new Error(invalidLaunchConfiguration(JSON.stringify(launchConfig))); | ||
marshalhayes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import * as assert from 'assert'; | ||
import { javaDebuggerExtension } from '../debugger/languages/java'; | ||
import { JavaLaunchConfiguration } from '../dcp/types'; | ||
|
||
suite('Java Debugger Extension Tests', () => { | ||
test('getProjectFile returns main_class_path when provided', () => { | ||
const mainClassPath = '/path/to/MainClass.java'; | ||
const launchConfig: JavaLaunchConfiguration = { | ||
type: 'java', | ||
main_class_path: mainClassPath, | ||
project_path: '/path/to/project' | ||
}; | ||
|
||
const result = javaDebuggerExtension.getProjectFile(launchConfig); | ||
|
||
assert.strictEqual(result, mainClassPath); | ||
}); | ||
|
||
test('getProjectFile returns project_path when main_class_path is not provided', () => { | ||
const projectPath = '/path/to/project'; | ||
const launchConfig: JavaLaunchConfiguration = { | ||
type: 'java', | ||
project_path: projectPath | ||
}; | ||
|
||
const result = javaDebuggerExtension.getProjectFile(launchConfig); | ||
|
||
assert.strictEqual(result, projectPath); | ||
}); | ||
|
||
test('getProjectFile throws error when neither main_class_path nor project_path is provided', () => { | ||
const launchConfig: JavaLaunchConfiguration = { | ||
type: 'java' | ||
}; | ||
|
||
assert.throws( | ||
() => javaDebuggerExtension.getProjectFile(launchConfig) | ||
); | ||
}); | ||
|
||
test('getProjectFile prefers main_class_path over project_path when both are provided', () => { | ||
const mainClassPath = '/path/to/MainClass.java'; | ||
const projectPath = '/path/to/project'; | ||
const launchConfig: JavaLaunchConfiguration = { | ||
type: 'java', | ||
main_class_path: mainClassPath, | ||
project_path: projectPath | ||
}; | ||
|
||
const result = javaDebuggerExtension.getProjectFile(launchConfig); | ||
|
||
assert.strictEqual(result, mainClassPath); | ||
}); | ||
|
||
test('getProjectFile throws error when launch configuration is not Java type', () => { | ||
const launchConfig = { | ||
type: 'python', | ||
program_path: '/path/to/program.py' | ||
}; | ||
|
||
assert.throws( | ||
() => javaDebuggerExtension.getProjectFile(launchConfig as any) | ||
); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.