-
Notifications
You must be signed in to change notification settings - Fork 799
Update Azure.Core to latest version - lift all runtime dependencies to latest #14361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14361Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14361" |
|
FYI - @joperezr @DamianEdwards - with the update to the latest Azure.Core (1.51.1), it is bringing in a bunch of v10 packages from dotnet/runtime unconditionally. See Azure/azure-sdk-for-net#54590 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adjusts central package versioning to accommodate dependency version lifts (in the context of updating Azure.Provisioning.AppContainers) by removing per-project “force latest” switches and updating centrally managed package versions.
Changes:
- Removed
ForceLatestDotnetVersionsfrom several OpenAI/Azure AI component, test, and playground projects. - Updated
Directory.Packages.propsto bumpAzure.Coreand restructure version groups, including pinning several runtime packages centrally. - Simplified conditional package version logic by removing the
ForceLatestDotnetVersionscondition from the net10 group.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.OpenAI.Tests/Aspire.OpenAI.Tests.csproj | Removes ForceLatestDotnetVersions property. |
| tests/Aspire.Azure.AI.OpenAI.Tests/Aspire.Azure.AI.OpenAI.Tests.csproj | Removes ForceLatestDotnetVersions property. |
| tests/Aspire.Azure.AI.Inference.Tests/Aspire.Azure.AI.Inference.Tests.csproj | Removes ForceLatestDotnetVersions property. |
| src/Components/Aspire.OpenAI/Aspire.OpenAI.csproj | Removes ForceLatestDotnetVersions property. |
| src/Components/Aspire.Azure.AI.OpenAI/Aspire.Azure.AI.OpenAI.csproj | Removes ForceLatestDotnetVersions property. |
| src/Components/Aspire.Azure.AI.Inference/Aspire.Azure.AI.Inference.csproj | Removes ForceLatestDotnetVersions property. |
| playground/OpenAIEndToEnd/OpenAIEndToEnd.WebStory/OpenAIEndToEnd.WebStory.csproj | Removes ForceLatestDotnetVersions property. |
| playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/GitHubModelsEndToEnd.WebStory.csproj | Removes ForceLatestDotnetVersions property. |
| playground/AzureOpenAIEndToEnd/AzureOpenAIEndToEnd.WebStory/AzureOpenAIEndToEnd.WebStory.csproj | Removes ForceLatestDotnetVersions property. |
| playground/AzureAIFoundryEndToEnd/AzureAIFoundryEndToEnd.WebStory/AzureAIFoundryEndToEnd.WebStory.csproj | Removes ForceLatestDotnetVersions property. |
| Directory.Packages.props | Bumps Azure.Core, restructures common/conditional version groups, and adds centrally pinned runtime package versions. |
Use latest versions for all dotnet/runtime nuget packages. This simplifies our dependency management. Remove ForceLatestDotnetVersions property from multiple project files
3a031cb to
8cca7da
Compare
Update to Azure.Core 1.51.1
Use latest versions for all dotnet/runtime nuget packages. This simplifies our dependency management. Too many of our dependencies are using v10 runtime packages it makes it hard to keep using transitive pinning and central package management. Aligning with the rest of the ecosystem and just always using latest.
Remove ForceLatestDotnetVersions property from multiple project files