No-op code gen under more cases

Author: captainsafia

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Emitters/ValidationsGenerator.Emitter.cs

@@ -21,6 +21,11 @@ public sealed partial class ValidationsGenerator : IIncrementalGenerator
 
     internal static void Emit(SourceProductionContext context, (InterceptableLocation? AddValidation, ImmutableArray<ValidatableType> ValidatableTypes) emitInputs)
     {
+        if (emitInputs.AddValidation is null)
+        {
+            // Avoid generating code if no AddValidation call was found.
+            return;
+        }
         var source = Emit(emitInputs.AddValidation, emitInputs.ValidatableTypes);
         context.AddSource("ValidatableInfoResolver.g.cs", SourceText.From(source, Encoding.UTF8));
     }

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Extensions/ITypeSymbolExtensions.cs

@@ -48,7 +48,7 @@ public static ITypeSymbol UnwrapType(this ITypeSymbol type, INamedTypeSymbol enu
             type = type.OriginalDefinition;
         }
 
-        if (type is INamedTypeSymbol namedType && namedType.IsEnumerable(enumerable))
+        if (type is INamedTypeSymbol namedType && namedType.IsEnumerable(enumerable) && namedType.TypeArguments.Length == 1)
         {
             // Extract the T from an IEnumerable<T> or List<T>
             type = namedType.TypeArguments[0];
@@ -86,4 +86,11 @@ internal static bool ImplementsInterface(this ITypeSymbol type, ITypeSymbol inte
 
         return derivedTypes.Count == 0 ? null : derivedTypes.ToImmutable();
     }
+
+    internal static bool IsExemptType(this ITypeSymbol type, RequiredSymbols requiredSymbols)
+    {
+        return SymbolEqualityComparer.Default.Equals(type, requiredSymbols.HttpContext)
+               || SymbolEqualityComparer.Default.Equals(type, requiredSymbols.HttpRequest)
+               || SymbolEqualityComparer.Default.Equals(type, requiredSymbols.HttpResponse);
+    }
 }

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Models/RequiredSymbols.cs

@@ -12,5 +12,8 @@ internal sealed record class RequiredSymbols(
     INamedTypeSymbol IValidatableObject,
     INamedTypeSymbol JsonDerivedTypeAttribute,
     INamedTypeSymbol RequiredAttribute,
-    INamedTypeSymbol CustomValidationAttribute
+    INamedTypeSymbol CustomValidationAttribute,
+    INamedTypeSymbol HttpContext,
+    INamedTypeSymbol HttpRequest,
+    INamedTypeSymbol HttpResponse
 );

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.RequiredSymbolsParser.cs

@@ -17,7 +17,10 @@ internal RequiredSymbols ExtractRequiredSymbols(Compilation compilation, Cancell
             compilation.GetTypeByMetadataName("System.ComponentModel.DataAnnotations.IValidatableObject")!,
             compilation.GetTypeByMetadataName("System.Text.Json.Serialization.JsonDerivedTypeAttribute")!,
             compilation.GetTypeByMetadataName("System.ComponentModel.DataAnnotations.RequiredAttribute")!,
-            compilation.GetTypeByMetadataName("System.ComponentModel.DataAnnotations.CustomValidationAttribute")!
+            compilation.GetTypeByMetadataName("System.ComponentModel.DataAnnotations.CustomValidationAttribute")!,
+            compilation.GetTypeByMetadataName("Microsoft.AspNetCore.Http.HttpContext")!,
+            compilation.GetTypeByMetadataName("Microsoft.AspNetCore.Http.HttpRequest")!,
+            compilation.GetTypeByMetadataName("Microsoft.AspNetCore.Http.HttpResponse")!
         );
     }
 }

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.TypesParser.cs

@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;
-using System.Threading;
 using Microsoft.AspNetCore.Analyzers.Infrastructure;
 using Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandlerModel;
 using Microsoft.CodeAnalysis;
@@ -46,6 +45,11 @@ internal bool TryExtractValidatableType(ITypeSymbol typeSymbol, RequiredSymbols
             return true;
         }
 
+        if (typeSymbol.IsExemptType(requiredSymbols))
+        {
+            return false;
+        }
+
         visitedTypes.Add(typeSymbol);
 
         // Extract validatable types discovered in base types of this type and add them to the top-level list.
@@ -105,34 +109,6 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
         return [.. members];
     }
 
-    public ImmutableArray<ITypeSymbol> ExtractPropertyTypes(ITypeSymbol type, CancellationToken cancellationToken)
-    {
-        var builder = ImmutableArray.CreateBuilder<ITypeSymbol>();
-        var processed = new HashSet<ITypeSymbol>(SymbolEqualityComparer.Default);
-
-        void Traverse(ITypeSymbol currentType)
-        {
-            if (currentType == null || currentType.SpecialType != SpecialType.None || processed.Contains(currentType))
-            {
-                return;
-            }
-
-            processed.Add(currentType);
-            builder.Add(currentType);
-
-            foreach (var member in currentType.GetMembers().OfType<IPropertySymbol>())
-            {
-                if (member.Type is ITypeSymbol propertyType)
-                {
-                    Traverse(propertyType);
-                }
-            }
-        }
-
-        Traverse(type);
-        return builder.ToImmutable();
-    }
-
     internal static ImmutableArray<ValidationAttribute> ExtractValidationAttributes(ISymbol symbol, RequiredSymbols requiredSymbols, out bool isRequired)
     {
         var attributes = symbol.GetAttributes();