Suppress obsolete warnings in test files and websites that use deprecated IActionContextAccessor

Copilot · captainsafia · Copilot · commit 8e5a83757485 · 2025-07-10T00:01:13.000Z
Co-authored-by: captainsafia &lt;1857993+captainsafia@users.noreply.github.com&gt;
diff --git a/src/Mvc/Mvc.RazorPages/test/Infrastructure/PageActionInvokerTest.cs b/src/Mvc/Mvc.RazorPages/test/Infrastructure/PageActionInvokerTest.cs
@@ -1565,7 +1565,9 @@ object pageFactory(PageContext context, ViewContext viewContext)
             selector.Object,
             diagnosticListener ?? new DiagnosticListener("Microsoft.AspNetCore"),
             logger ?? NullLogger.Instance,
+#pragma warning disable CS0618 // Type or member is obsolete
             ActionContextAccessor.Null,
+#pragma warning restore CS0618 // Type or member is obsolete
             new ActionResultTypeMapper(),
             pageContext,
             filters ?? Array.Empty<IFilterMetadata>(),
diff --git a/src/Mvc/test/WebSites/BasicWebSite/Startup.cs b/src/Mvc/test/WebSites/BasicWebSite/Startup.cs
@@ -20,7 +20,9 @@ public void ConfigureServices(IServiceCollection services)
         services.AddHttpContextAccessor();
         services.AddScoped<RequestIdService>();
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/BasicWebSite/StartupWithoutEndpointRouting.cs b/src/Mvc/test/WebSites/BasicWebSite/StartupWithoutEndpointRouting.cs
@@ -49,7 +49,9 @@ public void ConfigureServices(IServiceCollection services)
         services.AddScoped<RequestIdService>();
         services.AddTransient<ServiceActionFilter>();
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
         services.TryAddSingleton(CreateWeatherForecastService);
     }
 
diff --git a/src/Mvc/test/WebSites/Common/TestResponseGenerator.cs b/src/Mvc/test/WebSites/Common/TestResponseGenerator.cs
@@ -12,7 +12,9 @@ public class TestResponseGenerator
 {
     private readonly ActionContext _actionContext;
 
+#pragma warning disable CS0618 // Type or member is obsolete
     public TestResponseGenerator(IActionContextAccessor contextAccessor)
+#pragma warning restore CS0618 // Type or member is obsolete
     {
         _actionContext = contextAccessor.ActionContext;
         if (_actionContext == null)
diff --git a/src/Mvc/test/WebSites/GenericHostWebSite/Startup.cs b/src/Mvc/test/WebSites/GenericHostWebSite/Startup.cs
@@ -23,7 +23,9 @@ public void ConfigureServices(IServiceCollection services)
         services.AddLogging();
         services.AddHttpContextAccessor();
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/Startup.cs b/src/Mvc/test/WebSites/RoutingWebSite/Startup.cs
@@ -29,7 +29,9 @@ public void ConfigureServices(IServiceCollection services)
         ConfigureRoutingServices(services);
 
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public virtual void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForDynamic.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForDynamic.cs
@@ -18,7 +18,9 @@ public void ConfigureServices(IServiceCollection services)
 
         services.AddTransient<Transformer>();
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
 
         // Used by some controllers defined in this project.
         services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForDynamicOrder.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForDynamicOrder.cs
@@ -33,7 +33,9 @@ public void ConfigureServices(IServiceCollection services)
 
         services.AddTransient<Transformer>();
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
 
         // Used by some controllers defined in this project.
         services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForEndpointFilters.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForEndpointFilters.cs
@@ -17,7 +17,9 @@ public void ConfigureServices(IServiceCollection services)
         services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));
         services.AddScoped<TestResponseGenerator>();
         // This is used by test response generator
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public virtual void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForFallback.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForFallback.cs
@@ -16,7 +16,9 @@ public void ConfigureServices(IServiceCollection services)
             .AddNewtonsoftJson();
 
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
 
         // Used by some controllers defined in this project.
         services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForGroups.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForGroups.cs
@@ -17,7 +17,9 @@ public void ConfigureServices(IServiceCollection services)
         services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));
         services.AddScoped<TestResponseGenerator>();
         // This is used by test response generator
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public virtual void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupForLinkGenerator.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupForLinkGenerator.cs
@@ -31,7 +31,9 @@ public void ConfigureServices(IServiceCollection services)
             });
 
         services.AddScoped<TestResponseGenerator>();
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public void Configure(IApplicationBuilder app)
diff --git a/src/Mvc/test/WebSites/RoutingWebSite/StartupRoutingDifferentBranches.cs b/src/Mvc/test/WebSites/RoutingWebSite/StartupRoutingDifferentBranches.cs
@@ -31,7 +31,9 @@ public void ConfigureServices(IServiceCollection services)
 
         services.AddScoped<TestResponseGenerator>();
         // This is used by test response generator
+        #pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
         services.AddSingleton<BranchesTransformer>();
     }
 
diff --git a/src/Mvc/test/WebSites/VersioningWebSite/Startup.cs b/src/Mvc/test/WebSites/VersioningWebSite/Startup.cs
@@ -14,7 +14,9 @@ public void ConfigureServices(IServiceCollection services)
             .AddNewtonsoftJson();
 
         services.AddScoped<TestResponseGenerator>();
+#pragma warning disable CS0618 // Type or member is obsolete
         services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public virtual void Configure(IApplicationBuilder app)

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,9 @@ public void ConfigureServices(IServiceCollection services)`
`20`	`20`	`services.AddHttpContextAccessor();`
`21`	`21`	`services.AddScoped<RequestIdService>();`
`22`	`22`	`services.AddScoped<TestResponseGenerator>();`
	`23`	`+ #pragma warning disable CS0618 // Type or member is obsolete`
`23`	`24`	`services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();`
	`25`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`public void Configure(IApplicationBuilder app)`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,9 @@ public void ConfigureServices(IServiceCollection services)`
`49`	`49`	`services.AddScoped<RequestIdService>();`
`50`	`50`	`services.AddTransient<ServiceActionFilter>();`
`51`	`51`	`services.AddScoped<TestResponseGenerator>();`
	`52`	`+ #pragma warning disable CS0618 // Type or member is obsolete`
`52`	`53`	`services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();`
	`54`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`53`	`55`	`services.TryAddSingleton(CreateWeatherForecastService);`
`54`	`56`	`}`
`55`	`57`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,9 @@ public class TestResponseGenerator`
`12`	`12`	`{`
`13`	`13`	`private readonly ActionContext _actionContext;`
`14`	`14`
	`15`	`+#pragma warning disable CS0618 // Type or member is obsolete`
`15`	`16`	`public TestResponseGenerator(IActionContextAccessor contextAccessor)`
	`17`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`16`	`18`	`{`
`17`	`19`	`_actionContext = contextAccessor.ActionContext;`
`18`	`20`	`if (_actionContext == null)`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,9 @@ public void ConfigureServices(IServiceCollection services)`
`23`	`23`	`services.AddLogging();`
`24`	`24`	`services.AddHttpContextAccessor();`
`25`	`25`	`services.AddScoped<TestResponseGenerator>();`
	`26`	`+ #pragma warning disable CS0618 // Type or member is obsolete`
`26`	`27`	`services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();`
	`28`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`27`	`29`	`}`
`28`	`30`
`29`	`31`	`public void Configure(IApplicationBuilder app)`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,9 @@ public void ConfigureServices(IServiceCollection services)`
`29`	`29`	`ConfigureRoutingServices(services);`
`30`	`30`
`31`	`31`	`services.AddScoped<TestResponseGenerator>();`
	`32`	`+ #pragma warning disable CS0618 // Type or member is obsolete`
`32`	`33`	`services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();`
	`34`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`33`	`35`	`}`
`34`	`36`
`35`	`37`	`public virtual void Configure(IApplicationBuilder app)`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,9 @@ public void ConfigureServices(IServiceCollection services)`
`17`	`17`	`services.Configure<RouteOptions>(options => options.ConstraintMap["slugify"] = typeof(SlugifyParameterTransformer));`
`18`	`18`	`services.AddScoped<TestResponseGenerator>();`
`19`	`19`	`// This is used by test response generator`
	`20`	`+ #pragma warning disable CS0618 // Type or member is obsolete`
`20`	`21`	`services.AddSingleton<IActionContextAccessor, ActionContextAccessor>();`
	`22`	`+#pragma warning restore CS0618 // Type or member is obsolete`
`21`	`23`	`}`
`22`	`24`
`23`	`25`	`public virtual void Configure(IApplicationBuilder app)`