PR feedback

Author: JamesNK

src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/GrpcJsonSettings.cs

@@ -39,13 +39,13 @@ public sealed class GrpcJsonSettings
     /// </summary>
     /// <remarks>
     /// <para>
-    /// The Protobuf JSON specification requires JSON property names to match field names exactly, including case.
+    /// The Protobuf JSON specification requires JSON property names to match message field names exactly, including case.
     /// Enabling this option may reduce interoperability, as case-insensitive field matching might not be supported
     /// by other JSON transcoding implementations.
     /// </para>
     /// <para>
     /// For more information, see <see href="https://protobuf.dev/programming-guides/json/"/>.
     /// </para>
     /// </remarks>
-    public bool FieldNamesCaseInsensitive { get; set; }
+    public bool PropertyNameCaseInsensitive { get; set; }
 }

src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/JsonConverterHelper.cs

@@ -47,7 +47,7 @@ internal static JsonSerializerOptions CreateSerializerOptions(JsonContext contex
             NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals,
             Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
             TypeInfoResolver = typeInfoResolver,
-            PropertyNameCaseInsensitive = context.Settings.FieldNamesCaseInsensitive,
+            PropertyNameCaseInsensitive = context.Settings.PropertyNameCaseInsensitive,
         };
         options.Converters.Add(new NullValueConverter());
         options.Converters.Add(new ByteStringConverter());

src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/PublicAPI.Unshipped.txt

@@ -1,3 +1,3 @@
 #nullable enable
-Microsoft.AspNetCore.Grpc.JsonTranscoding.GrpcJsonSettings.FieldNamesCaseInsensitive.get -> bool
-Microsoft.AspNetCore.Grpc.JsonTranscoding.GrpcJsonSettings.FieldNamesCaseInsensitive.set -> void
+Microsoft.AspNetCore.Grpc.JsonTranscoding.GrpcJsonSettings.PropertyNameCaseInsensitive.get -> bool
+Microsoft.AspNetCore.Grpc.JsonTranscoding.GrpcJsonSettings.PropertyNameCaseInsensitive.set -> void

src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs

@@ -66,7 +66,7 @@ public void NonJsonName_CaseInsensitive()
   ""HIDING_FIELD_NAME"": ""A field name""
 }";
 
-        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
         Assert.Equal("A field name", m.HidingFieldName);
     }
 
@@ -77,7 +77,7 @@ public void HidingJsonName_CaseInsensitive()
   ""FIELD_NAME"": ""A field name""
 }";
 
-        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
         Assert.Equal("", m.FieldName);
         Assert.Equal("A field name", m.HidingFieldName);
     }
@@ -89,7 +89,7 @@ public void JsonCustomizedName_CaseInsensitive()
   ""JSON_CUSTOMIZED_NAME"": ""A field name""
 }";
 
-        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var m = AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
         Assert.Equal("A field name", m.FieldName);
     }
 
@@ -486,7 +486,7 @@ public void MapMessages_CaseInsensitive()
   }
 }";
 
-        AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
     }
 
     [Fact]
@@ -547,7 +547,7 @@ public void OneOf_CaseInsensitive_Success()
   ""ONEOFNAME1"": ""test""
 }";
 
-        AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        AssertReadJson<HelloRequest>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
     }
 
     [Fact]
@@ -569,7 +569,7 @@ public void OneOf_CaseInsensitive_Failure()
   ""ONEOFNAME2"": ""test""
 }";
 
-        AssertReadJsonError<HelloRequest>(json, ex => Assert.Equal("Multiple values specified for oneof oneof_test", ex.Message.TrimEnd('.')), deserializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        AssertReadJsonError<HelloRequest>(json, ex => Assert.Equal("Multiple values specified for oneof oneof_test", ex.Message.TrimEnd('.')), deserializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
     }
 
     [Fact]
@@ -634,7 +634,7 @@ public void NullableWrappers_CaseInsensitive()
   ""BYTESVALUE"": ""SGVsbG8gd29ybGQ=""
 }";
 
-        var result = AssertReadJson<HelloRequest.Types.Wrappers>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var result = AssertReadJson<HelloRequest.Types.Wrappers>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
         Assert.Equal("A string", result.StringValue);
     }
 
@@ -728,7 +728,7 @@ public void JsonNamePriority_CaseInsensitive_JsonName()
     {
         var json = @"{""B"":10,""A"":20,""D"":30}";
 
-        var m = AssertReadJson<Issue047349Message>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var m = AssertReadJson<Issue047349Message>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
 
         Assert.Equal(10, m.A);
         Assert.Equal(20, m.B);
@@ -752,7 +752,7 @@ public void JsonNamePriority_CaseInsensitive_FieldNameFallback()
     {
         var json = @"{""B"":10,""A"":20,""C"":30}";
 
-        var m = AssertReadJson<Issue047349Message>(json, serializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        var m = AssertReadJson<Issue047349Message>(json, serializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
 
         Assert.Equal(10, m.A);
         Assert.Equal(20, m.B);
@@ -775,7 +775,7 @@ public void FieldNameCase_CaseInsensitive_Failure()
     {
         var json = @"{""a"":10,""A"":20}";
 
-        AssertReadJsonError<FieldNameCaseMessage>(json, ex => Assert.Equal("The JSON property name for 'Transcoding.FieldNameCaseMessage.A' collides with another property.", ex.Message), deserializeOld: false, settings: new GrpcJsonSettings { FieldNamesCaseInsensitive = true });
+        AssertReadJsonError<FieldNameCaseMessage>(json, ex => Assert.Equal("The JSON property name for 'Transcoding.FieldNameCaseMessage.A' collides with another property.", ex.Message), deserializeOld: false, settings: new GrpcJsonSettings { PropertyNameCaseInsensitive = true });
     }
 
     private TValue AssertReadJson<TValue>(string value, GrpcJsonSettings? settings = null, DescriptorRegistry? descriptorRegistry = null, bool serializeOld = true) where TValue : IMessage, new()