Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 28, 2023

Attempt to resolve #47912

@wtgodbe wtgodbe requested review from a team and eerhardt June 28, 2023 15:17
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@eerhardt
Copy link
Member

Can we remove this as well:

aspnetcore/.globalconfig

Lines 13 to 14 in 22a6b51

# TODO: remove this - https://github.com/dotnet/aspnetcore/issues/47912
dotnet_diagnostic.EnableGenerateDocumentationFile.severity = none

@Tratcher
Copy link
Member

Microsoft.Extensions.Caching.SqlServer -> D:\a_work\1\s\artifacts\bin\Microsoft.Extensions.Caching.SqlServer\Release\net8.0\Microsoft.Extensions.Caching.SqlServer.dll
CSC : error EnableGenerateDocumentationFile: Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640) [D:\a_work\1\s\src\Framework\AspNetCoreAnalyzers\src\Analyzers\Microsoft.AspNetCore.App.Analyzers.csproj]
##[error]CSC(0,0): error EnableGenerateDocumentationFile: (NETCORE_ENGINEERING_TELEMETRY=Build) Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640)
Microsoft.Extensions.Caching.SqlServer -> D:\a_work\1\s\artifacts\bin\Microsoft.Extensions.Caching.SqlServer\Release\netstandard2.0\Microsoft.Extensions.Caching.SqlServer.dll
CSC : error EnableGenerateDocumentationFile: Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640) [D:\a_work\1\s\src\Components\Analyzers\src\Microsoft.AspNetCore.Components.Analyzers.csproj]
##[error]CSC(0,0): error EnableGenerateDocumentationFile: (NETCORE_ENGINEERING_TELEMETRY=Build) Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640)
Microsoft.Extensions.Caching.SqlServer -> D:\a_work\1\s\artifacts\bin\Microsoft.Extensions.Caching.SqlServer\Release\net462\Microsoft.Extensions.Caching.SqlServer.dll
Microsoft.Extensions.Caching.StackExchangeRedis -> D:\a_work\1\s\artifacts\bin\Microsoft.Extensions.Caching.StackExchangeRedis\Release\net462\Microsoft.Extensions.Caching.StackExchangeRedis.dll
Task :core:generateVersionClass
CSC : error EnableGenerateDocumentationFile: Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640) [D:\a_work\1\s\src\Http\Http.Extensions\gen\Microsoft.AspNetCore.Http.RequestDelegateGenerator.csproj]
##[error]CSC(0,0): error EnableGenerateDocumentationFile: (NETCORE_ENGINEERING_TELEMETRY=Build) Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640)
Microsoft.AspNetCore.JsonPatch -> D:\a_work\1\s\artifacts\bin\Microsoft.AspNetCore.JsonPatch\Release\net8.0\Microsoft.AspNetCore.JsonPatch.dll

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 7, 2023
@RussKie
Copy link
Contributor

RussKie commented Jul 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amcasey
Copy link
Member

amcasey commented Jul 24, 2023

@wtgodbe Can/should I convert this to a draft PR?

@wtgodbe wtgodbe marked this pull request as draft July 24, 2023 19:36
@shuebner
Copy link

shuebner commented Aug 7, 2023

fyi if you don't want the unnecessary xml doc file in the output directory, there is another way of doing this:
See https://github.com/shuebner/CheckUnnecessaryUsings/blob/main/configs/CheckUnnecessaryUsings.targets

@wtgodbe
Copy link
Member Author

wtgodbe commented Aug 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mitchdenny
Copy link
Member

Very old PR ... is this still needed?

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment Feb 13, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 27, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member Author

wtgodbe commented May 14, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable IDE0005 analyzer in the build

9 participants