Date only and time only is not supported in blazor change detection for parameters #55914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
@MackinnonBuck, may I please request a review for this. |
There was a problem hiding this comment.
Thanks @MattyLeslie! Looks good so far - just a few suggestions. Let me know if you'd like me to take it from here.
Comment on lines
55
to
66
| public static event Action? OnHotReload; | ||
|
|
||
| public static void ClearImmutableTypeCache() | ||
| { | ||
| _immutableNonObjectTypesCache.Clear(); | ||
| } | ||
|
|
||
| public static void HotReloadHandler() | ||
| { | ||
| ClearImmutableTypeCache(); | ||
| OnHotReload?.Invoke(); | ||
| } |
There was a problem hiding this comment.
It doesn't look like this hooks into the hot reload OnDeltaApplied event, so the cache will never get cleared.
This can all probably be reduced down to something like what we do for RouteView:
aspnetcore/src/Components/Components/src/RouteView.cs
Lines 23 to 29 in 870eec2
|
@MackinnonBuck If you're will to carry it over the line that would be great otherwise I'll address that feedback as soon as I get time. |
…mmutableAndUnchanged" test to account for the new behaviours of DateOnly and TimeOnly.
MackinnonBuck
force-pushed
the
DateOnly-and-TimeOnly-is-not-supported-in-Blazor-change-detection-for-parameters
branch
from
800f788 to
77fd269
Compare
MackinnonBuck
approved these changes
Oct 21, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
#55914) Co-authored-by: Mackinnon Buck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DateOnly and TimeOnly support in Blazor change detection
Summary of the changes (Less than 80 chars)
Add DateOnly and TimeOnly as known immutable types in Blazor change detection.
Description
Updated the
ChangeDetectionclass to includeDateOnlyandTimeOnlyin theIsKnownImmutableTypemethod. Introduced a caching mechanism to store immutability checks results using aConcurrentDictionary<T, U>for performance optimization. Added support for hot reload to clear the cache when a hot reload event occurs.Fixes #49021