Skip to content

[release/6.0] Prepend ? when dealing with runtime query string prefixes #56837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[release/6.0] Prepend ? when dealing with runtime query string prefixes #56837

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fefa854
Prepend ? when dealing with runtime query string prefixes
mmitche Jul 16, 2024
f60be83
Update DownloadFile.cs
mmitche Jul 16, 2024
96bc2fa
Update DownloadFile.cs
mmitche Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions eng/tools/RepoTasks/DownloadFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ private async System.Threading.Tasks.Task<bool> ExecuteAsync()
{
var uriSuffixBytes = System.Convert.FromBase64String(PrivateUriSuffix);
uriSuffix = System.Text.Encoding.UTF8.GetString(uriSuffixBytes);

// Ensure that the url suffix starts with the query string prefix
if (!uriSuffix.StartsWith('?'))
{
uriSuffix = $"?{uriSuffix}";
}
}
downloadStatus = await DownloadWithRetriesAsync($"{PrivateUri}{uriSuffix}", DestinationPath, errorMessages);
}
Expand Down