Skip to content

Note fire-and-forget status of HubConnection event tasks #57779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Note fire-and-forget status of HubConnection event tasks #57779

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a43e88e
Note fire-and-forget status of HubConnection event tasks
Smaug123 Sep 10, 2024
8d11670
Merge branch 'main' into hubconnection-fire-and-forget
Smaug123 Jan 20, 2025
87f954a
Stop using exact words fire-and-forget
Smaug123 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ public partial class HubConnection : IAsyncDisposable
/// If this event was triggered from a connection error, the <see cref="Exception"/> that occurred will be passed in as the
/// sole argument to this handler. If this event was triggered intentionally by either the client or server, then
/// the argument will be <see langword="null"/>.
///
/// The <see cref="Task"/> result is fire-and-forget: the <see cref="HubConnection"/> does not wait for it to complete.
/// </remarks>
/// <example>
/// The following example attaches a handler to the <see cref="Closed"/> event, and checks the provided argument to determine
Expand All @@ -123,6 +125,8 @@ public partial class HubConnection : IAsyncDisposable
/// </summary>
/// <remarks>
/// The <see cref="Exception"/> that occurred will be passed in as the sole argument to this handler.
///
/// The <see cref="Task"/> result is fire-and-forget: the <see cref="HubConnection"/> does not wait for it to complete.
/// </remarks>
/// <example>
/// The following example attaches a handler to the <see cref="Reconnecting"/> event, and checks the provided argument to log the error.
Expand All @@ -141,6 +145,8 @@ public partial class HubConnection : IAsyncDisposable
/// </summary>
/// <remarks>
/// The <see cref="string"/> parameter will be the <see cref="HubConnection"/>'s new ConnectionId or null if negotiation was skipped.
///
/// The <see cref="Task"/> result is fire-and-forget: the <see cref="HubConnection"/> does not wait for it to complete.
/// </remarks>
/// <example>
/// The following example attaches a handler to the <see cref="Reconnected"/> event, and checks the provided argument to log the ConnectionId.
Expand Down