Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Sep 17, 2024

It's possible to end up with the package.json files for the node packages having the same version as the target version, typically if you cancel the build at just the right time and the package.json files end up edited. I think this can also happen if one of the node commands fails and leaves the backup files

It's possible to end up with the package.json files for the node packages having the same version as the target version, typically if you cancel the build at just the right time and the package.json files end up edited. I think this can also happen if one of the node commands fails and leaves the backup files
@mmitche mmitche requested review from a team and wtgodbe as code owners September 17, 2024 17:02
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 17, 2024
@wtgodbe wtgodbe requested a review from javiercn September 17, 2024 17:03
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @javiercn should confirm as well

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 24, 2024
@mmitche
Copy link
Member Author

mmitche commented Sep 25, 2024

@javiercn Any concerns here?

@mmitche mmitche closed this Jun 25, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants