Skip to content

Quarantine and fix Http1Connection_RequestEndsWithIncompleteReadAsync #57946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Quarantine and fix Http1Connection_RequestEndsWithIncompleteReadAsync #57946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Servers/Kestrel/test/InMemory.FunctionalTests/KestrelMetricsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ await connection.ReceiveEnd(
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57944")]
Copy link
Member Author

@halter73 halter73 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think quarantining is even necessary this time? I'm confident in the fix.

Copy link
Member

@JamesNK JamesNK Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half the work in the process is creating an issue. You've already done that. May as well follow the rest of the process.

public async Task Http1Connection_RequestEndsWithIncompleteReadAsync()
{
var testMeterFactory = new TestMeterFactory();
Expand All @@ -171,7 +172,12 @@ public async Task Http1Connection_RequestEndsWithIncompleteReadAsync()
await using var server = new TestServer(async context =>
{
var result = await context.Request.BodyReader.ReadAsync();
await context.Response.BodyWriter.WriteAsync(result.Buffer.ToArray());

// The request body might be incomplete, but there should be something in the first read.
Assert.True(result.Buffer.Length > 0);
Assert.Equal(result.Buffer.ToSpan(), "Hello World?"u8[..(int)result.Buffer.Length]);

await context.Response.WriteAsync("Hello World?");
// No BodyReader.Advance. Connection will fail when attempting to complete body.
}, serviceContext);

Expand Down
Loading