Skip to content

Unquarantine fixed tests that have not failed in 30 days #57978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Unquarantine fixed tests that have not failed in 30 days #57978

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0313933
Unquarantine https://github.com/dotnet/aspnetcore/issues/54754
halter73 Sep 20, 2024
bc6dbaa
Unquarantine https://github.com/dotnet/aspnetcore/issues/54447
halter73 Sep 20, 2024
763b6c6
Unquarantine https://github.com/dotnet/aspnetcore/issues/57153
halter73 Sep 20, 2024
acc6e23
Unquarantine https://github.com/dotnet/aspnetcore/issues/47967
halter73 Sep 20, 2024
efbbf3b
Unquarantine https://github.com/dotnet/aspnetcore/issues/57259
halter73 Sep 20, 2024
bb76b9b
Revert "Unquarantine https://github.com/dotnet/aspnetcore/issues/57259"
halter73 Sep 20, 2024
e861fd1
Revert "Unquarantine https://github.com/dotnet/aspnetcore/issues/57153"
halter73 Sep 22, 2024
54ce196
Add back InternalTesting using
halter73 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
using Microsoft.AspNetCore.E2ETesting;
using Microsoft.AspNetCore.InternalTesting;
using OpenQA.Selenium;
using TestServer;
using Xunit.Abstractions;
Expand All @@ -25,7 +24,6 @@ public override Task InitializeAsync()
=> InitializeAsync(BrowserFixture.RoutingTestContext);

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")]
public void NavigationIsLockedAfterPrerendering()
{
Navigate("/locked-navigation");
Expand Down
2 changes: 0 additions & 2 deletions ...s/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
using Microsoft.AspNetCore.E2ETesting;
using Microsoft.AspNetCore.InternalTesting;
using OpenQA.Selenium;
using TestServer;
using Xunit.Abstractions;
Expand Down Expand Up @@ -1251,7 +1250,6 @@ public void PostingFormWithErrorsDoesNotExceedMaximumErrors()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54447")]
public void CanBindToFormWithFiles()
{
var profilePicture = TempFile.Create(_tempDirectory, "txt", "This is a profile picture.");
Expand Down
4 changes: 0 additions & 4 deletions src/Components/test/E2ETest/Tests/RoutingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
using Microsoft.AspNetCore.E2ETesting;
using Microsoft.AspNetCore.InternalTesting;
using OpenQA.Selenium;
using OpenQA.Selenium.Interactions;
using Xunit.Abstractions;
Expand Down Expand Up @@ -1085,7 +1084,6 @@ public void NavigationLock_HistoryNavigationWorks_AfterRefresh()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")]
public void NavigationLock_CanBlockExternalNavigation()
{
SetUrlViaPushState("/");
Expand Down Expand Up @@ -1679,7 +1677,6 @@ public void AnchorWithHrefToSameUrlWithParamQueryAndHash_ScrollsToElementOnTheSa
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/47967")]
public void AnchorWithHrefContainingHashAnotherPage_NavigatesToPageAndScrollsToElement()
{
SetUrlViaPushState("/");
Expand All @@ -1696,7 +1693,6 @@ public void AnchorWithHrefContainingHashAnotherPage_NavigatesToPageAndScrollsToE
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/47967")]
public void NavigationManagerNavigateToAnotherUrlWithHash_NavigatesToPageAndScrollsToElement()
{
SetUrlViaPushState("/");
Expand Down
5 changes: 0 additions & 5 deletions src/Components/test/E2ETest/Tests/ThreadingAppTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,12 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
Copy link
Member Author

@halter73 halter73 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MackinnonBuck I saw you mention in this issue that the test failures may be caused by dotnet/runtime#106788 which is still open.

However, you still kept the test-fixed label on the issue and I don't see any ThreadingAppTests failing at https://dev.azure.com/dnceng-public/public/_test/analytics?definitionId=84&contextType=build. Do you think these are safe to unquarantine?

public void HasTitle()
{
Assert.Equal("Blazor standalone", Browser.Title);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
public void HasHeading()
{
Assert.Equal("Hello, world!", Browser.Exists(By.TagName("h1")).Text);
Expand Down Expand Up @@ -69,7 +67,6 @@ public void NavMenuHighlightsCurrentLocation()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
public void CounterPageCanUseThreads()
{
// Navigate to "Counter"
Expand All @@ -87,7 +84,6 @@ public void CounterPageCanUseThreads()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
public void HasFetchDataPage()
{
// Navigate to "Fetch data"
Expand All @@ -109,7 +105,6 @@ public void HasFetchDataPage()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
public void IsStarted()
{
// Read from property
Expand Down
1 change: 0 additions & 1 deletion src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ namespace Microsoft.AspNetCore.Hosting.Tests;
public class HostingApplicationDiagnosticsTests : LoggedTest
{
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")]
public async Task EventCountersAndMetricsValues()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ public void UnhandledException()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")]
public async Task VerifyCountersFireWithCorrectValues()
{
// Arrange
Expand Down
Loading