Skip to content

Quarantine Http1Connection_ServerAbort_HasErrorType #58087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Quarantine Http1Connection_ServerAbort_HasErrorType #58087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca26340
Quarantine Http1Connection_ServerAbort_HasErrorType
JamesNK Sep 26, 2024
10d4c49
Clean up
JamesNK Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/KestrelMetricsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ await connection.ReceiveEnd(
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/58086")]
public async Task Http1Connection_ServerAbort_HasErrorType()
{
var testMeterFactory = new TestMeterFactory();
Expand All @@ -399,17 +400,25 @@ public async Task Http1Connection_ServerAbort_HasErrorType()
var serviceContext = new TestServiceContext(LoggerFactory, metrics: new KestrelMetrics(testMeterFactory));

var sendString = "POST / HTTP/1.0\r\nContent-Length: 12\r\n\r\nHello World?";
var finishedSendingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await using var server = new TestServer(c =>
await using var server = new TestServer(async c =>
{
await c.Request.Body.ReadUntilEndAsync();

// An extra check to ensure that client is done sending before the server aborts.
// This might not be necessary since we're reading to the end of the request body, but it doesn't hurt.
await finishedSendingTcs.Task;

c.Abort();
return Task.CompletedTask;
}, serviceContext);

using (var connection = server.CreateConnection())
{
await connection.Send(sendString).DefaultTimeout();

finishedSendingTcs.SetResult();

await connection.ReceiveEnd().DefaultTimeout();

await connection.WaitForConnectionClose().DefaultTimeout();
Expand Down
Loading