Skip to content

Fixed to not throw an exception when password is null. #58168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fixed to not throw an exception when password is null. #58168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10d935a
Fixed to not throw an exception when password is null.
Sep 30, 2024
a7b8e66
Update src/Identity/test/Identity.Test/PasswordValidatorTest.cs
halter73 Oct 1, 2024
6cf039f
Update src/Identity/test/Identity.Test/PasswordValidatorTest.cs
halter73 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Identity/Extensions.Core/src/PasswordValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ public PasswordValidator(IdentityErrorDescriber? errors = null)
/// <returns>The task object representing the asynchronous operation.</returns>
public virtual Task<IdentityResult> ValidateAsync(UserManager<TUser> manager, TUser user, string? password)
{
ArgumentNullThrowHelper.ThrowIfNull(password);
ArgumentNullThrowHelper.ThrowIfNull(manager);
List<IdentityError>? errors = null;
var options = manager.Options.Password;
password ??= "";
if (string.IsNullOrWhiteSpace(password) || password.Length < options.RequiredLength)
{
errors ??= new List<IdentityError>();
Expand Down
10 changes: 5 additions & 5 deletions src/Identity/test/Identity.Test/PasswordValidatorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ public async Task ValidateThrowsWithNullTest()

// Act
// Assert
await Assert.ThrowsAsync<ArgumentNullException>("password", () => validator.ValidateAsync(null, null, null));
await Assert.ThrowsAsync<ArgumentNullException>("manager", () => validator.ValidateAsync(null, null, "foo"));
}

[Theory]
[InlineData("")]
[InlineData("abc")]
[InlineData("abcde")]
public async Task FailsIfTooShortTests(string input)
[InlineData(null)]
[InlineData("")]
[InlineData("abc")]
[InlineData("abcde")]
public async Task FailsIfPasswordIsNullOrTooShort(string input)
{
const string error = "Passwords must be at least 6 characters.";
var manager = MockHelpers.TestUserManager<PocoUser>();
Expand Down
Loading