Skip to content

Retry ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate test #58170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Retry ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate test #58170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/test-configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"retryOnRules": [
{"testName": {"contains": "FlakyTestToEnsureRetryWorks" }},
{"testName": {"contains": "MaxRequestBufferSizeTests.LargeUpload" }}, // tries to manipulate the state of the server's buffer
{"testName": {"contains": "ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate"}}, // Issue: https://github.com/dotnet/aspnetcore/issues/58169
Copy link
Member

@amcasey amcasey Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use comments to explain why a test is inherently flaky and would benefit from a retry. If we haven't established that, I might just quarantine it.

Copy link
Member Author

@sebastienros sebastienros Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we haven't established that, I might just quarantine it.

I don't really disagree, and honestly I first created the issue to do so, but then I looked again at the operations docs and it suggested to first move it in retries and then escalate to quarantine if it doesn't help. I couldn't find anything that would suggest retrying would not help, there have been other builds without the issue even if it happened twice this week AFAIK.

Copy link
Member Author

@sebastienros sebastienros Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we decide that it's the same GH issue to track, then I agree this would also be quarantined. I will trust your judgement here since I have no other arguments to just retry.

Copy link
Member

@amcasey amcasey Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other test started in the retry list and was promoted to quarantine, so I think we should probably skip straight to that. Let's start with updating the existing bug - we can always split it out later. Thanks!

{"testName": {"contains": "CertificateChangedOnDisk"}}, // depends on FS event timing
{"testName": {"contains": "CertificateChangedOnDisk_Symlink"}}, // depends on FS event timing
{"testName": {"contains": "CanLaunchPhotinoWebViewAndClickButton"}},
Expand Down
Loading