Enable code analysis and address initial set of issues. #58304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
BrennanConroy,
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
adityamandaleeka
force-pushed
the
ancm_ca_changes_incr
branch
from
8c02c1c to
7aa9be1
Compare
src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/dllmain.cpp
Show resolved
Hide resolved
BrennanConroy
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #58167.
This continues work @BrennanConroy started, with some modifications. Most notably, C26477 (nullptr) has been handled. I also made an effort to isolate different kinds of changes in each commit to make reviewing (and potential future reverts) easier.
We'll continue to work on this area, but it doesn't make sense to delay reviewing this any longer so here it is.