Remove dead code and clean up multisz/a and stringa #58373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
BrennanConroy,
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
BrennanConroy
approved these changes
Oct 11, 2024
|
|
||
| if ( fLockedHeap ) | ||
| { | ||
| fLockedHeap = FALSE; |
There was a problem hiding this comment.
Is there an analyzer warning about setting a local without ever reading it again? Not sure how I feel about that in the general case 😆
For this file it's fine since we don't touch it.
There was a problem hiding this comment.
Haha, I hit that while trying out clang-tidy locally and fixed it in this super obvious case.
|
Disabled auto-merge... CI took long enough to get another cleanup commit in 😆. |
adityamandaleeka
changed the title
BrennanConroy
approved these changes
Oct 14, 2024
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some dead code while touching ANCM stuff recently. This cleans up a bunch of that, and also re-enables some suppressed warnings in the affected files (and includes the associated fixes).
@BrennanConroy