Skip to content

Fix flaky Http2WebSocket Kestrel test #58448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix flaky Http2WebSocket Kestrel test #58448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2WebSocketTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,18 @@ await InitializeConnectionAsync(async context =>
[Fact]
public async Task ExtendedCONNECTMethod_CanHaveNon200ResponseWithBody()
{
var finishedSendingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await InitializeConnectionAsync(async context =>
{
var connectFeature = context.Features.Get<IHttpExtendedConnectFeature>();
Assert.True(connectFeature.IsExtendedConnect);

// The EndStreamReceived flag might not have been sent let alone received by the server by the time application code completes
// which would result in a RST_STREAM being sent to the client. We wait for the data frame to finish sending
// before allowing application code to complete (relies on inline Pipe completions which we use for tests)
await finishedSendingTcs.Task;

context.Response.StatusCode = Http.StatusCodes.Status418ImATeapot;
context.Response.ContentLength = 2;
await context.Response.Body.WriteAsync(new byte[1] { 0x01 });
Expand All @@ -543,6 +550,8 @@ await InitializeConnectionAsync(async context =>

await SendDataAsync(1, new byte[10241], endStream: true);

finishedSendingTcs.SetResult();

var headersFrame = await ExpectAsync(Http2FrameType.HEADERS,
withLength: 40,
withFlags: (byte)Http2HeadersFrameFlags.END_HEADERS,
Expand Down
Loading