Skip to content

if actual bytes to be written is negative, set to zero #58575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024
Merged

if actual bytes to be written is negative, set to zero #58575

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd918f0
wait for window updates, if stream window becomes negative
bhaskarqlik Oct 22, 2024
d19b336
update comment
bhaskarqlik Oct 23, 2024
14017a0
fix typo
bhaskarqlik Oct 23, 2024
79f1461
update comment per suggestion
bhaskarqlik Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Servers/Kestrel/Core/src/Internal/Http2/Http2FrameWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ private async Task WriteToOutputPipe()
// Now check the connection window
actual = CheckConnectionWindow(actual);

// reset to zero, if negative
// actual is negative means window size has become negative
// this can usually happen if the receiver decreases window size before receiving the previous data frame
// in this case, reset to 0 and continue, no data will be set but will wait for window update
if (actual < 0)
{
actual = 0;
Expand Down
Loading