Fix local failure in GET_GracefulServerShutdown_AbortRequestsAfterHostTimeout #58747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
area-networking
JamesNK
requested review from
BrennanConroy,
halter73 and
mgravell
as code owners
src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Nov 6, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally there was a 5 second timeout on an await that waited for shutdown event in 5 seconds. It fail with a timeout.
I looked at the flakyness of the test at the same time but couldn't figure it out.