Skip to content

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
14eee79
Update .NET SDK
github-actions[bot] Nov 4, 2024
f30edff
Fix build errors
sebastienros Nov 4, 2024
3007125
Revert changes
sebastienros Nov 4, 2024
1f9529c
Update XUnit package
sebastienros Nov 4, 2024
b647ece
Fix build errors
sebastienros Nov 4, 2024
9962cc5
Fix arrays
sebastienros Nov 4, 2024
d66e6c5
Fix Http tests
sebastienros Nov 4, 2024
e52323e
Fix more errors
sebastienros Nov 4, 2024
540cf1a
Fix MVC
sebastienros Nov 4, 2024
0f9d339
Flip around where AsSpan is called with string comparisons in tests.
eerhardt Nov 6, 2024
0af0f15
Include package path prefix on Identity UI packages
javiercn Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
<RelativePath>%(RecursiveDir)%(FileName)%(Extension)</RelativePath>
</V5AssetsCandidates>
</ItemGroup>

<DefineStaticWebAssets Condition="'@(V4AssetsCandidates->Count())' != '0'" CandidateAssets="@(V4AssetsCandidates)" SourceId="$(PackageId)" SourceType="Discovered" AssetKind="All" ContentRoot="assets/V4" BasePath="$(StaticWebAssetBasePath)">
<Output TaskParameter="Assets" ItemName="V4Assets" />
</DefineStaticWebAssets>
Expand All @@ -106,7 +106,7 @@
>
<Output TaskParameter="Endpoints" ItemName="V4AssetEndpoints" />
</DefineStaticWebAssetEndpoints>

<DefineStaticWebAssetEndpoints
Condition="'@(V5Assets)' != ''"
CandidateAssets="@(V5Assets)"
Expand All @@ -122,11 +122,13 @@
<GenerateStaticWebAssetEndpointsPropsFile
StaticWebAssets="@(V4Assets)"
StaticWebAssetEndpoints="@(V4AssetEndpoints)"
PackagePathPrefix="staticwebassets/V4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what changed to break this? Is this a sign of some underlying bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know yet, but I plan to look at it on Monday, at a quick glance, the endpoints in the package are incorrect too (we will have to service that).

It doesn't currently fail I think because we have a process to "upgrade" older packages and define endpoints and the endpoints end up being generated as part of the user build.

Not sure what the difference is between the build in the repo and the end user build that causes it to fail here. In the end, it's a bug in the package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed an issue to track

TargetPropsFilePath="$(IntermediateOutputPath)IdentityUI.V4.endpoints.targets" />

<GenerateStaticWebAssetEndpointsPropsFile
StaticWebAssets="@(V5Assets)"
StaticWebAssetEndpoints="@(V5AssetEndpoints)"
PackagePathPrefix="staticwebassets/V5"
TargetPropsFilePath="$(IntermediateOutputPath)IdentityUI.V5.endpoints.targets" />

<ComputeStaticWebAssetsTargetPaths Assets="@(V4Assets)" PathPrefix="staticwebassets/V4" AdjustPathsForPack="true">
Expand Down
Loading