Skip to content

Build installers at the end of the repo build and allow building with desktop msbuild #58987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 26, 2024
Merged

Build installers at the end of the repo build and allow building with desktop msbuild #58987

merged 7 commits into from
Nov 26, 2024

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 15, 2024 •
edited
Loading

Fixes #58984
Unblocks dotnet/sdk#44828 (removes the patch)
Depends on #59150

  • Build the Installer projects after everything else got built by using Arcade's new BuildStep metadata.
  • Allow building the entire repository from a single build invocation.
  • When using desktop msbuild, build the entire repository from a single build invocation.
  • Condition SharedFrameworkBundle.wixproj correctly when building inside the VMR.

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@ViktorHofer ViktorHofer requested review from a team and wtgodbe as code owners November 15, 2024 15:47
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2024
@ViktorHofer ViktorHofer added the * NO MERGE * Do not merge this PR as long as this label is present. label Nov 15, 2024
@ViktorHofer
Copy link
Member Author

Adding the NO MERGE label until I fully tested the changes inside the VMR

@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch from 4de0a68 to acd5702 Compare November 15, 2024 16:02
@wtgodbe
Copy link
Member

wtgodbe commented Nov 19, 2024

Local Development job failures are unrelated

@ViktorHofer ViktorHofer marked this pull request as draft November 19, 2024 17:25
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 2 times, most recently from ec997da to 1504eaf Compare November 21, 2024 12:04
@ViktorHofer ViktorHofer marked this pull request as ready for review November 21, 2024 12:05
@ViktorHofer ViktorHofer changed the title Build installers at the end of the repo build Build installers at the end of the repo build and allow building with desktop msbuild Nov 21, 2024
@ViktorHofer
Copy link
Member Author

@ellahathaway this will fix the Sign and Publish issue as well inside the VMR.

@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 4 times, most recently from 1eb05c2 to 10a83ad Compare November 21, 2024 17:06
@ellahathaway ellahathaway mentioned this pull request Nov 21, 2024
Merged
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 12 times, most recently from 1d6cb7c to de94095 Compare November 22, 2024 10:29
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 2 times, most recently from 4e3b499 to dd10a42 Compare November 25, 2024 09:31
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch 2 times, most recently from 4c4051e to e980b37 Compare November 25, 2024 13:02
@ViktorHofer ViktorHofer force-pushed the BuildInstallersAtTheEndOfTheRepoBuild branch from 56be416 to 8f18412 Compare November 25, 2024 15:20
ViktorHofer added a commit to dotnet/arcade that referenced this pull request Nov 25, 2024
@ViktorHofer
Allow build targets to be invoked in specific batches.
391a83f 
Enables building the aspnetcore repo with a single eng\build.cmd invocation (when using desktop msbuild).

Unblocks dotnet/sdk#44828 & dotnet/aspnetcore#58987
@ViktorHofer ViktorHofer mentioned this pull request Nov 25, 2024
Merged
@ViktorHofer
Copy link
Member Author

Needs #59150

wtgodbe
wtgodbe reviewed Nov 25, 2024
View reviewed changes
wtgodbe
wtgodbe reviewed Nov 25, 2024
View reviewed changes
@ViktorHofer @wtgodbe
Update eng/Build.props
1cf00be 
Co-authored-by: William Godbe <[email protected]>
wtgodbe
wtgodbe reviewed Nov 25, 2024
View reviewed changes
@wtgodbe
Copy link
Member

wtgodbe commented Nov 25, 2024

Is there any reason we can't update the Windows build in ci/ci-public.yml to use the new one-pass build.cmd invocation you mentioned on Teams?

wtgodbe
wtgodbe approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@ViktorHofer ViktorHofer mentioned this pull request Nov 25, 2024
Open
@ViktorHofer
Copy link
Member Author

Is there any reason we can't update the Windows build in ci/ci-public.yml to use the new one-pass build.cmd invocation you mentioned on Teams?

If you are OK with building everything with desktop msbuild, sure. From reading some of the comments in the build.ps1 file, that doesn't seem to be the case though. I filed #59151 to track whether dotnet msbuild can also be used as the entry-point to build everything.

@ViktorHofer ViktorHofer removed the * NO MERGE * Do not merge this PR as long as this label is present. label Nov 25, 2024
@ViktorHofer ViktorHofer merged commit e778af9 into main Nov 26, 2024
27 checks passed
@ViktorHofer ViktorHofer deleted the BuildInstallersAtTheEndOfTheRepoBuild branch November 26, 2024 07:55
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 26, 2024
@ViktorHofer ViktorHofer mentioned this pull request Nov 26, 2024
Merged
4 tasks
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@ViktorHofer @wtgodbe @captainsafia
Build installers at the end of the repo build and allow building with…
608c048 
… desktop msbuild (#58987)

* Condition SharedFrameworkBundle correctly and remove an incorrect warnings

* Build updates

* Use Aracade's BuildStep metadata

* Condition installers correctly

* Update buildstep metadata

* Update eng/Build.props

Co-authored-by: William Godbe <[email protected]>

* Update Build.props

---------

Co-authored-by: William Godbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

-BuildManaged -BuildInstallers doesn't work as installer build too early

2 participants

@ViktorHofer @wtgodbe