Use the Installers Arcade package to build the ref pack and targeting pack installers #59406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with how the build is structured in CI.
ghost
added
the
area-infrastructure
jkoritzinsky
added
the
blocked
jkoritzinsky
requested review from
NikolaMilosavljevic and
ViktorHofer
and removed request for
a team
ViktorHofer
approved these changes
Dec 12, 2024
|
@ViktorHofer we should have waited to merge this until the Arcade changes flowed. The shared framework bundle installer won't work until those changes have flowed through here. It's fine, we just need to keep an eye out. |
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
… pack installers (#59406) * Use the Installers Arcade package to build the ref pack MSI * Convert Shared Framework msi to use the Installer shared tooling. * Remove now-unused file * Adjust the conditions for adding the installer targets to work better with how the build is structured in CI. * Remove deleted wixprojs from Build.props and Installers.slnf. * Migrate the Shared Framework bundle to use the installer SDK (with arcade changes) * Disable package validation * The bundleproj isn't packable * Remove dead reference * Pass the full path to the sharedfx installers instead of just the file name * We need to pass the name due to other reasons, pass what we need to construct the paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Installers Arcade package to build the ref pack and targeting pack installers
Use the Arcade tooling to reduce the maintenance burden for common installable components.
Blocked on dotnet/arcade#15321
If we merge this before Preview 1, we don't need to worry about changing the upgrade codes.
Description
By moving to using the Arcade tooling, ASP.NET Core no longer needs to maintain any custom logic for these common installers. The Arcade tooling automatically provides the wixpack logic as well as the VS component insertion package logic. Additionally, this work means that all installers used to construct the .NET SDK outside of the SDK repo use the same logic to be built.