Skip to content

Added APIReviewPrinciples document #59880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 15, 2025
Merged

Added APIReviewPrinciples document #59880

merged 7 commits into from
Jan 15, 2025

Conversation

@mkArtakMSFT
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT commented Jan 15, 2025

Adding a place to store learnings and knowledge as it emerges through the API Review process.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 15, 2025
Copilot AI reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@mkArtakMSFT mkArtakMSFT requested a review from Copilot January 15, 2025 00:17
Copilot AI reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@mkArtakMSFT mkArtakMSFT requested a review from Copilot January 15, 2025 00:18
Copilot AI reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

mkArtakMSFT
mkArtakMSFT commented Jan 15, 2025
View reviewed changes
@mkArtakMSFT mkArtakMSFT requested a review from Copilot January 15, 2025 00:22
Copilot AI reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

halter73
halter73 approved these changes Jan 15, 2025
View reviewed changes
terrajobst
terrajobst approved these changes Jan 15, 2025
View reviewed changes
Copy link

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first stab

mkArtakMSFT and others added 2 commits January 14, 2025 18:36
@mkArtakMSFT mkArtakMSFT merged commit a7c124a into main Jan 15, 2025
22 of 23 checks passed
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/apiReview branch January 15, 2025 05:45
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 15, 2025
@JamesNK JamesNK mentioned this pull request Jan 16, 2025
Merged
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@mkArtakMSFT
@halter73 @captainsafia
Added APIReviewPrinciples document (#59880)
3739d8f 
* Added APIReviewPrinciples document

* Update docs/APIReviewPrinciples.md

Co-authored-by: Copilot <[email protected]>

* Update docs/APIReviewProcess.md

Co-authored-by: Copilot <[email protected]>

* Update docs/APIReviewProcess.md

Co-authored-by: Copilot <[email protected]>

* Update docs/APIReviewProcess.md

* Update docs/APIReviewPrinciples.md

Co-authored-by: Stephen Halter <[email protected]>

* Update docs/APIReviewPrinciples.md

Co-authored-by: Stephen Halter <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Stephen Halter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@halter73 halter73 halter73 approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

+1 more reviewer

@terrajobst terrajobst terrajobst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@mkArtakMSFT @halter73 @terrajobst