-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Attempted fix on flaky counter tests #59892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
captainsafia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall!
Was the inaccurate totalRequestValues.WaitForSumValueAsync causing the flakiness or something else? I'd expect it to be a logical bug that would always cause the tests to fail instead of just being flaky.
Summing was always wrong for this value. But it is only a problem if it takes multiple seconds to get the right values. If the first set of values are correct then it doesn't have to sum and it passes. I also much improved the logging for this test so if there are still problems then they should be more easier to observe. |
13d9f94 to
fe0be7b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
I noticed that #57259 is still flaky after the latest changes. 4 failures in the last 30 days.
For some reason I thought it would be a good idea to sum the results from the total request counter. This doesn't make any sense 🤷 Maybe I was thinking of RPS counter when I did it. Total request counter is pre-summed so change the test back to test the latest value.
I've also made a change to improve logging and debugging the counter methods.