Skip to content

Fix Handle Leak of ReadableJsonConfigurationProvider in FromStdInStrategy class #59959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Handle Leak of ReadableJsonConfigurationProvider in FromStdInStrategy class #59959

wants to merge 1 commit into from

Conversation

@Anchels
Copy link

@Anchels Anchels commented Jan 20, 2025 •
edited
Loading

Fix Handle Leak of ReadableJsonConfigurationProvider in FromStdInStrategy class

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Add the using statement to ensure proper disposal.

Fixes #59260

Found by Linux Verification Center (linuxtesting.org) with SVACE.

@ghost ghost added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Jan 20, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 20, 2025
@dotnet-policy-service
Copy link
Contributor

Thanks for your PR, @Anchels. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@build-analysis build-analysis bot mentioned this pull request Jan 20, 2025
Closed
3 tasks
@dotnet-policy-service
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 27, 2025
@danmoseley danmoseley requested a review from Copilot February 14, 2025 03:56
Copilot AI reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

danmoseley
danmoseley approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@danmoseley danmoseley enabled auto-merge (squash) February 14, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@danmoseley danmoseley danmoseley approved these changes

Assignees

No one assigned

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle Leak of ReadableJsonConfigurationProvider in FromStdInStrategy class

2 participants

@Anchels @danmoseley