Skip to content

[Infrastructure] Fixes the dependency update script for selenium and playwright #60089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

[Infrastructure] Fixes the dependency update script for selenium and playwright #60089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-selenium-and-playwright-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
pull-requests: write

jobs:
update-jquery-validate:
update-selenium-and-playwright:
runs-on: ubuntu-latest

steps:
Expand Down
13 changes: 8 additions & 5 deletions eng/scripts/update-selenium-and-playwright-versions.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,12 @@ exit 1
}

# Check if there are changes
if (-not (git diff --cached --quiet)) {
git diff --quiet
if ($LASTEXITCODE -eq 0) {
Write-Host "No changes to commit."
exit 0
# exit 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that this is now commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this was actually my mistake

}else {
Write-Host "Updating the version of packages";
}

# Create a new branch
Expand All @@ -93,9 +96,9 @@ git add eng/Versions.props src/Components/benchmarkapps/Wasm.Performance/dockerf
# Commit the changes
$commitMessage = @"
[Infrastructure] Update Selenium and Playwright dependencies $(Get-Date -Format "yyyy-MM-dd")
* Updated Playwright version to $($versions["Microsoft.Playwright"])
* Updated Selenium version to $($versions["Selenium.Support"])
* Updated Selenium version to $($versions["Selenium.WebDriver"])
* Updated Microsoft.Playwright version to $($versions["Microsoft.Playwright"])
* Updated Selenium.Support version to $($versions["Selenium.Support"])
* Updated Selenium.WebDriver version to $($versions["Selenium.WebDriver"])
"@
git commit -m $commitMessage

Expand Down
Loading