Skip to content

Check length of TypeArguments before accessing via index #60742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Check length of TypeArguments before accessing via index #60742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b67fcd
Check length of TypeArguments before accessing via index
benhopkinstech Mar 4, 2025
92f9bb3
Removed unecessary using in associated test
benhopkinstech Mar 4, 2025
5f0d976
Fixed a spelling mistake
benhopkinstech Mar 6, 2025
b3854fd
Added comments around the additional check
benhopkinstech Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...tCoreAnalyzers/src/Analyzers/RouteHandlers/DisallowNonParsableComplexTypesOnParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private static void DisallowNonParsableComplexTypesOnParameters(
continue;
}

var parameterTypeSymbol = ResovleParameterTypeSymbol(handlerDelegateParameter);
var parameterTypeSymbol = ResolveParameterTypeSymbol(handlerDelegateParameter);

// If this is null it means we aren't working with a named type symbol.
if (parameterTypeSymbol == null)
Expand Down Expand Up @@ -113,7 +113,7 @@ static bool ReportFromAttributeDiagnostic(OperationAnalysisContext context, Well
return false;
}

static INamedTypeSymbol? ResovleParameterTypeSymbol(IParameterSymbol parameterSymbol)
static INamedTypeSymbol? ResolveParameterTypeSymbol(IParameterSymbol parameterSymbol)
{
INamedTypeSymbol? parameterTypeSymbol = null;

Expand All @@ -127,8 +127,10 @@ static bool ReportFromAttributeDiagnostic(OperationAnalysisContext context, Well
parameterTypeSymbol = namedTypeSymbol;
}

// If it is nullable, unwrap it.
if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T)
// If it is nullable and we have type arguments, unwrap it.
// The length check aims to alleviate AD0001 warnings when referencing methods in external class libraries that contain parameters
if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T &&
parameterTypeSymbol.TypeArguments.Length > 0)
{
parameterTypeSymbol = parameterTypeSymbol.TypeArguments[0] as INamedTypeSymbol;
}
Expand Down
1 change: 0 additions & 1 deletion ...AspNetCoreAnalyzers/test/RouteHandlers/DisallowNonParsableComplexTypesOnParametersTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Security.Policy;
using Microsoft.CodeAnalysis.Testing;
using VerifyCS = Microsoft.AspNetCore.Analyzers.Verifiers.CSharpAnalyzerVerifier<Microsoft.AspNetCore.Analyzers.RouteHandlers.RouteHandlerAnalyzer>;

Expand Down
Loading