Skip to content

Use trim-safe ValidationContext constructor and update RuntimeParameterInfoResolver #60976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

Use trim-safe ValidationContext constructor and update RuntimeParameterInfoResolver #60976

merged 4 commits into from
Mar 19, 2025

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Mar 17, 2025

  • Use the new trim-safe ValidationContext constructor in the ValidationEndpointFilterFactory and remove suppressions.
  • Update RuntimeParameterInfoResolver to skip parameters that have no validation attributes and won't have validatable types.

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Mar 17, 2025
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Mar 17, 2025
@captainsafia captainsafia changed the title Use trim-safe ValiationContext constructor and update RuntimeParameterInfoResolver Use trim-safe ValidationContext constructor and update RuntimeParameterInfoResolver Mar 17, 2025
BrennanConroy
BrennanConroy reviewed Mar 17, 2025
View reviewed changes
BrennanConroy
BrennanConroy reviewed Mar 18, 2025
View reviewed changes
@captainsafia captainsafia enabled auto-merge (squash) March 18, 2025 20:27
@captainsafia captainsafia merged commit d0cd312 into main Mar 19, 2025
27 checks passed
@captainsafia captainsafia deleted the safia/fix-paraminfo-resolver branch March 19, 2025 03:25
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc

Projects

None yet

Milestone

10.0-preview3

Development

Successfully merging this pull request may close these issues.

3 participants

@captainsafia @BrennanConroy