Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 18, 2025

Should cover the rest of #60146

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2666582&view=results

Had to do some msbuild trickery to get the build ordering correct - hooked a manual target named _VmrBuild into the SiteExtensions dependency projects, and disabled restoring w/ Nuget.Targets in pass 2 so I could hook targets before Restore

@wtgodbe wtgodbe requested a review from a team as a code owner March 18, 2025 21:54
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 18, 2025
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this infra was written from the ground (creating the SiteExtension package for the first time), what would we do differently?

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 18, 2025

If this infra was written from the ground (creating the SiteExtension package for the first time), what would we do differently?

I'd consider getting rid of the meta-package (LoggingAggregate) entirely, and publishing the input x64/x86 as shipping packages instead. I believe the meta-package is just a convenience to allow devs to only have to reference one thing (CC @BrennanConroy for confirmation).

@BrennanConroy
Copy link
Member

I assume we have both x86 and x64 in the same package because we wanted to make it easier for people using it in Azure App Service. Since you could run your site as either x86 or x64 it was nicer to have a single package with both so they didn't need to make sure they picked the right one.

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 18, 2025

In that case maybe we'd get rid of the x64 and x86 packages (which are nonshipping) and bundle their logic into the LoggingAggregate package

@wtgodbe wtgodbe merged commit 2ac1078 into main Mar 19, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/SiteExtensionsInVmr branch March 19, 2025 16:48
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants