Skip to content

Pass thru command line args to RepoTasks build #61040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 20, 2025
Merged

Pass thru command line args to RepoTasks build #61040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a06b5fd
Pass thru command line args to RepoTasks build
wtgodbe Mar 20, 2025
7f0d7c9
Fixup
wtgodbe Mar 20, 2025
f3d14b2
Fixup
wtgodbe Mar 20, 2025
b3fdc2b
Spacing
wtgodbe Mar 20, 2025
d560d52
Append
wtgodbe Mar 20, 2025
ef709f5
Remove comment
wtgodbe Mar 20, 2025
e3cf2ba
Fixup
wtgodbe Mar 20, 2025
c134b56
Consistency
wtgodbe Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ if ($BuildManaged -or ($All -and (-not $NoBuildManaged))) {
}
}

$CommandLineArguments = $MSBuildArguments

if ($NoBuildDeps) { $MSBuildArguments += "/p:BuildProjectReferences=false" }

$RunBuild = if ($NoBuild) { $false } else { $true }
Expand Down Expand Up @@ -478,7 +480,8 @@ try {
/p:Restore=$RunRestore `
/p:Build=true `
/clp:NoSummary `
@ToolsetBuildArguments
@ToolsetBuildArguments `
@CommandLineArguments
}

if (-not $OnlyBuildRepoTasks) {
Expand Down
10 changes: 10 additions & 0 deletions eng/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ while [[ $# -gt 0 ]]; do
shift
done

commandline_args=()

if [ ${#msbuild_args[@]} -gt 0 ]; then
commandline_args=("${msbuild_args[@]}")
fi

if [ "$build_all" = true ]; then
msbuild_args[${#msbuild_args[*]}]="-p:BuildAllProjects=true"
fi
Expand Down Expand Up @@ -388,6 +394,10 @@ InitializeToolset

restore=$_tmp_restore=

if [ ${#commandline_args[@]} -gt 0 ]; then
toolset_build_args+=("${commandline_args[@]}")
fi

if [ "$build_repo_tasks" = true ]; then
MSBuild $_InitializeToolset \
-p:RepoRoot="$repo_root" \
Expand Down
Loading