Update accessibility check for types in same assembly #61082
Merged
+111
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
captainsafia
added
area-mvc
| SymbolEqualityComparer.Default.Equals(symbol.ContainingAssembly, assemblySymbol); | ||
| private bool IsAccessibleType(ISymbol symbol) => | ||
| SymbolEqualityComparer.Default.Equals(symbol.ContainingAssembly, assemblySymbol) | ||
| && (symbol.DeclaredAccessibility == Accessibility.Public || |
Member
There was a problem hiding this comment.
Is it simpler to check for != Accessibility.Private? Or are there more accessibility states I'm forgetting?
Member
Author
There was a problem hiding this comment.
The way the Accessibility enum is modeled is kinda weird. It does it based on the modifiers in the class so protected class Foo will have Accessibility.Protected even though it is private.
| /// <summary> | ||
| /// No XML comment processed here. | ||
| /// </summary> | ||
| private class Element |
Member
There was a problem hiding this comment.
Doesn't this type need to be used somewhere so we can check the lack of description?
Member
Author
There was a problem hiding this comment.
We have to rely on the check for compilation errors for this one. Since the type is private, we can't actually use it in the parameter list or return list for a method handler that is internal and/or public.
martincostello
approved these changes
Mar 21, 2025
BrennanConroy
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61037.
Also uncomments some tests that were commented out due to a bug in Microsoft.OpenApi.