Skip to content

Api proposal fix for NavLink.ShouldMatch #61151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Api proposal fix for NavLink.ShouldMatch #61151

merged 2 commits into from
Mar 25, 2025

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Mar 25, 2025

Rename currentUriAbsolute to uriAbsolute

Description

Applying the change from API review. To keep the local variables in line with the rename, currentUriAbsoluteSpan -> uriAbsoluteSpan was done as well.

Fixes #61137

@ilonatommy ilonatommy added the area-blazor Includes: Blazor, Razor Components label Mar 25, 2025
@ilonatommy ilonatommy added this to the .NET 10 Planning milestone Mar 25, 2025
@ilonatommy ilonatommy requested a review from halter73 March 25, 2025 07:28
@ilonatommy ilonatommy self-assigned this Mar 25, 2025
@ilonatommy ilonatommy requested a review from a team as a code owner March 25, 2025 07:28
@ilonatommy ilonatommy merged commit 7ab2cc4 into dotnet:main Mar 25, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@halter73 halter73 Awaiting requested review from halter73

Assignees

@ilonatommy ilonatommy

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

10.0-preview4

Development

Successfully merging this pull request may close these issues.

Api proposal for NavLink.ShouldMatch

2 participants

@ilonatommy @javiercn