Skip to content

Do not use Wix targets to sign intermediates #61173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

Do not use Wix targets to sign intermediates #61173

merged 3 commits into from
Mar 27, 2025
+2 −14

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Mar 26, 2025 •
edited
Loading

These are signed using signtool. The wix targets are significantly slower due to single-file-submissions

@mmitche mmitche requested review from a team and wtgodbe as code owners March 26, 2025 20:01
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 26, 2025
wtgodbe
wtgodbe approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the test builds work

@mmitche
Copy link
Member Author

mmitche commented Mar 26, 2025

UB test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2672603&view=results
aspnetcore CI: https://dev.azure.com/dnceng/internal/_build/results?buildId=2672608&view=results

@build-analysis build-analysis bot mentioned this pull request Mar 26, 2025
Closed
3 tasks
@mmitche
Copy link
Member Author

mmitche commented Mar 26, 2025

https://dev.azure.com/dnceng/internal/_build/results?buildId=2672754&view=results

@mmitche
Copy link
Member Author

mmitche commented Mar 26, 2025

https://dev.azure.com/dnceng/internal/_build/results?buildId=2672755&view=results

@mmitche mmitche merged commit d24486f into dotnet:main Mar 27, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview4

Development

Successfully merging this pull request may close these issues.

2 participants

@mmitche @wtgodbe