Harden AddValidation check in validations generator #61193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-networking
| public static class SomeExtensions | ||
| { | ||
| public static IServiceCollection AddValidation(this IServiceCollection services, string someString) |
Member
There was a problem hiding this comment.
Should we make this match the current signature of AddValidation?
Member
Author
There was a problem hiding this comment.
I couldn't quite figure out how to do that without the overload resolution favoring the AddValidation overload that is declared in the assembly. I suppose we could update the invocation code use a static method to call AddValidation instead of the extension method form.
captainsafia
added
area-minimal
BrennanConroy
approved these changes
Mar 27, 2025
This was referenced Mar 28, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #61177.